Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: test/mjsunit/regress/regress-crbug-514081.js

Issue 2697723004: Make regress-crbug-514081 less flaky by having max serialization size (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/mjsunit/mjsunit.status ('K') | « test/mjsunit/mjsunit.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/regress/regress-crbug-514081.js
diff --git a/test/mjsunit/regress/regress-crbug-514081.js b/test/mjsunit/regress/regress-crbug-514081.js
index af31f4b9c6ceed6e74e5deea65f03d0b7b12e19b..51ea69a89eec628884cde6bc54a275ef7cdd9f04 100644
--- a/test/mjsunit/regress/regress-crbug-514081.js
+++ b/test/mjsunit/regress/regress-crbug-514081.js
@@ -2,19 +2,18 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+// Flags: --max-serializer-memory-usage=1000
Michael Achenbach 2017/02/15 09:35:24 Maybe we need to blacklist this flag on our intern
binji 2017/02/15 20:31:55 I removed the flag instead, as suggested by Yang.
if (this.Worker) {
var __v_7 = new Worker('onmessage = function() {};');
var e;
+ var ab = new ArrayBuffer(2000);
try {
- var ab = new ArrayBuffer(2147483648);
- try {
- __v_7.postMessage(ab);
- } catch (e) {
- // postMessage failed, should be a DataCloneError message.
- assertContains('cloned', e.message);
- }
+ __v_7.postMessage(ab);
+ threw = false;
} catch (e) {
- // Creating the ArrayBuffer failed.
- assertInstanceof(e, RangeError);
+ // postMessage failed, should be a DataCloneError message.
+ assertContains('cloned', e.message);
+ threw = true;
}
+ assertTrue(threw, 'Should throw when trying to serialize large message.');
}
« test/mjsunit/mjsunit.status ('K') | « test/mjsunit/mjsunit.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698