content/test/data/allowed_frames.html - Issue 2697713003: Initial Implementation of Iframe Attribute for Feature Policy (Part 2)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/allowed_frames.html

Issue 2697713003: Initial Implementation of Iframe Attribute for Feature Policy (Part 2) (Closed)

Patch Set: Initial Impl Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>iframes with allow attribute</title>

	5 </head>

	6 <body>

	7 cross-site iframes:
	iclelland 2017/02/16 15:26:33 I think we should remove these labels; I don't thi I think we should remove these labels; I don't think they're adding any value to the test file. lunalu1 2017/02/16 20:16:15 Done. Show quoted text On 2017/02/16 15:26:33, iclelland wrote: > I think we should remove these labels; I don't think they're adding any value to > the test file. Done.
	8 <iframe name="frame1" id="child-1" allow="fullscreen vibrate" src="/cross-site /bar.com/title1.html"></iframe>

	9 same-site iframes:

	10 <iframe name="frame2" id="child-2" allow="fullscreen vibrate" src="title1.html "></iframe>
	iclelland 2017/02/16 15:26:33 In addition to these two, I'd like to have a coupl In addition to these two, I'd like to have a couple of other tests on this attribute (I'm not sure this file is the right place, but I think so): <iframe allow="" src="..."> (empty allow attribute) <iframe src="..."> (no allow attribute) To ensure that we can properly transfer and read an empty allow attribute. WDYT?
	11 </body>

	12 </html>

	13

OLD	NEW