Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(803)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: content/test/data/allowed_frames.html
Issue
2697713003
:
Initial Implementation of Iframe Attribute for Feature Policy (Part 2) (Closed)
Patch Set: Update rebase
Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
content/browser/DEPS
content/browser/site_per_process_browsertest.cc
content/common/frame_messages.h
content/common/frame_owner_properties.h
content/common/frame_owner_properties.cc
content/renderer/frame_owner_properties.cc
content/test/data/allowed_frames.html
third_party/WebKit/Source/core/frame/FrameOwner.h
third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h
third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
third_party/WebKit/Source/core/html/HTMLIFrameElement.h
third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
third_party/WebKit/Source/web/RemoteFrameOwner.h
third_party/WebKit/Source/web/WebFrame.cpp
third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
third_party/WebKit/public/web/WebFrameOwnerProperties.h
View unified diff
|
Download patch
« no previous file with comments
|
« content/renderer/frame_owner_properties.cc
('k') |
third_party/WebKit/Source/core/frame/FrameOwner.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<head>
3
</head>
4
<body>
5
<iframe name="frame0" id="child-0"></iframe>
6
<iframe name="frame1" id="child-1" allow></iframe>
7
<iframe name="frame2" id="child-2" allow="fullscreen vibrate" src="/cross-site /bar.com/title1.html"></iframe>
8
<iframe name="frame3" id="child-3" allow="fullscreen vibrate" src="title1.html "></iframe>
9
</body>
10
</html>
11
OLD
NEW
« no previous file with comments
|
« content/renderer/frame_owner_properties.cc
('k') |
third_party/WebKit/Source/core/frame/FrameOwner.h »
('j') |
no next file with comments »
Issue 2697713003: Initial Implementation of Iframe Attribute for Feature Policy (Part 2) (Closed)
Created 3 years, 10 months ago by lunalu1
Modified 3 years, 10 months ago
Reviewers: iclelland, pfeldman, kenrb, nasko
Base URL:
Comments: 14
This is Rietveld
408576698
Chromium Code Reviews
Issue 2697713003:
Initial Implementation of Iframe Attribute for Feature Policy (Part 2) (Closed)
