Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Unified Diff: components/translate/core/browser/mock_translate_ranker.h

Issue 2697703004: Allow TranslateRanker to override decisions taken by heuristics. (Closed)
Patch Set: Make ShouldSuppressBubbleUI easier to read. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/mock_translate_ranker.h
diff --git a/components/translate/core/browser/mock_translate_ranker.h b/components/translate/core/browser/mock_translate_ranker.h
index ea71eb8e31fe9b36d90dc975bc27a4f9fc2b6324..f2e9d446649fdc66b4ca7e9ce6a3d693842a75cb 100644
--- a/components/translate/core/browser/mock_translate_ranker.h
+++ b/components/translate/core/browser/mock_translate_ranker.h
@@ -10,6 +10,7 @@
#include <vector>
#include "components/translate/core/browser/translate_ranker.h"
+#include "testing/gmock/include/gmock/gmock.h"
class GURL;
@@ -31,23 +32,31 @@ class MockTranslateRanker : public TranslateRanker {
void set_is_logging_enabled(bool val) { is_logging_enabled_ = val; }
void set_is_query_enabled(bool val) { is_query_enabled_ = val; }
void set_is_enforcement_enabled(bool val) { is_enforcement_enabled_ = val; }
+ void set_is_decision_override_enabled(bool val) {
+ is_decision_override_enabled_ = val;
+ }
void set_model_version(int val) { model_version_ = val; }
void set_should_offer_translation(bool val) {
should_offer_translation_ = val;
}
// TranslateRanker Implementation:
- bool IsLoggingEnabled() override;
- bool IsQueryEnabled() override;
- bool IsEnforcementEnabled() override;
- int GetModelVersion() const override;
- bool ShouldOfferTranslation(const TranslatePrefs& translate_prefs,
- const std::string& src_lang,
- const std::string& dst_lang) override;
- void AddTranslateEvent(const metrics::TranslateEventProto& translate_event,
- const GURL& url) override;
+ uint32_t GetModelVersion() const override;
+ bool ShouldOfferTranslation(
+ const TranslatePrefs& translate_prefs,
+ const std::string& src_lang,
+ const std::string& dst_lang,
+ metrics::TranslateEventProto* translate_events) override;
void FlushTranslateEvents(
std::vector<metrics::TranslateEventProto>* events) override;
+ MOCK_METHOD3(RecordTranslateEvent,
+ void(int event_type,
+ const GURL& url,
+ metrics::TranslateEventProto* translate_event));
+ MOCK_METHOD3(ShouldOverrideDecision,
+ bool(int event_type,
+ const GURL& url,
+ metrics::TranslateEventProto* translate_event));
private:
std::vector<metrics::TranslateEventProto> event_cache_;
@@ -55,6 +64,7 @@ class MockTranslateRanker : public TranslateRanker {
bool is_logging_enabled_ = false;
bool is_query_enabled_ = false;
bool is_enforcement_enabled_ = false;
+ bool is_decision_override_enabled_ = false;
bool model_version_ = 0;
bool should_offer_translation_ = true;

Powered by Google App Engine
This is Rietveld 408576698