Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: components/translate/core/browser/mock_translate_ranker.cc

Issue 2697703004: Allow TranslateRanker to override decisions taken by heuristics. (Closed)
Patch Set: Merge & Cleanup commented code. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/mock_translate_ranker.cc
diff --git a/components/translate/core/browser/mock_translate_ranker.cc b/components/translate/core/browser/mock_translate_ranker.cc
index 2c9418f83a10891291781e4a9dccc4566dedd699..a96813add84f53ad58f75d0b4b52fdee87b2be3c 100644
--- a/components/translate/core/browser/mock_translate_ranker.cc
+++ b/components/translate/core/browser/mock_translate_ranker.cc
@@ -14,35 +14,18 @@ MockTranslateRanker::MockTranslateRanker() {}
MockTranslateRanker::~MockTranslateRanker() {}
-bool MockTranslateRanker::IsLoggingEnabled() {
- return is_logging_enabled_;
-}
-
-bool MockTranslateRanker::IsQueryEnabled() {
- return is_query_enabled_;
-}
-
-bool MockTranslateRanker::IsEnforcementEnabled() {
- return is_enforcement_enabled_;
-}
-
-int MockTranslateRanker::GetModelVersion() const {
+uint32_t MockTranslateRanker::GetModelVersion() const {
return model_version_;
}
bool MockTranslateRanker::ShouldOfferTranslation(
const TranslatePrefs& /* translate_prefs */,
const std::string& /* src_lang */,
- const std::string& /* dst_lang */) {
+ const std::string& /* dst_lang */,
+ metrics::TranslateEventProto* /*translate_event */) {
return should_offer_translation_;
}
-void MockTranslateRanker::AddTranslateEvent(
- const metrics::TranslateEventProto& translate_event,
- const GURL& /* url */) {
- event_cache_.push_back(translate_event);
-}
-
void MockTranslateRanker::FlushTranslateEvents(
std::vector<metrics::TranslateEventProto>* events) {
events->swap(event_cache_);

Powered by Google App Engine
This is Rietveld 408576698