Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: components/translate/core/browser/translate_ranker.cc

Issue 2697703004: Allow TranslateRanker to override decisions taken by heuristics. (Closed)
Patch Set: Nit. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ranker.cc
diff --git a/components/translate/core/browser/translate_ranker.cc b/components/translate/core/browser/translate_ranker.cc
index fe2a214ee397936d1210379f595bfeac9c99b616..ccb71208dc468a7113129d44b2747d37dfeb2aa5 100644
--- a/components/translate/core/browser/translate_ranker.cc
+++ b/components/translate/core/browser/translate_ranker.cc
@@ -82,6 +82,9 @@ const base::Feature kTranslateRankerEnforcement{
const base::Feature kTranslateRankerLogging{"TranslateRankerLogging",
base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kTranslateRankerDecisionOverride{
+ "TranslateRankerDecisionOverride", base::FEATURE_DISABLED_BY_DEFAULT};
+
TranslateRanker::~TranslateRanker() {}
// static
@@ -101,7 +104,14 @@ bool TranslateRanker::IsQueryEnabled() {
// static
bool TranslateRanker::IsEnforcementEnabled() {
- return base::FeatureList::IsEnabled(kTranslateRankerEnforcement);
+ return base::FeatureList::IsEnabled(kTranslateRankerEnforcement) ||
+ IsDecisionOverrideEnabled();
+}
+
+//static
+bool TranslateRanker::IsDecisionOverrideEnabled() {
+ return base::FeatureList::IsEnabled(
+ translate::kTranslateRankerDecisionOverride);
}
// static

Powered by Google App Engine
This is Rietveld 408576698