Allow TranslateRanker to override decisions taken by heuristics.

components/translate/core/browser/translate_ranker_impl_unittest.cc

Index: components/translate/core/browser/translate_ranker_impl_unittest.cc
diff --git a/components/translate/core/browser/translate_ranker_impl_unittest.cc b/components/translate/core/browser/translate_ranker_impl_unittest.cc
index 885f14e75e65a0541e2f32795e89f9c3f8b8a053..e0801e67460fee5184ab2060b8fc7ee6b7ee4235 100644
--- a/components/translate/core/browser/translate_ranker_impl_unittest.cc
+++ b/components/translate/core/browser/translate_ranker_impl_unittest.cc
@@ -32,6 +32,7 @@ namespace {
 using translate::kTranslateRankerEnforcement;
 using translate::kTranslateRankerLogging;
 using translate::kTranslateRankerQuery;
+using translate::kTranslateRankerDecisionOverride;
 using translate::TranslateDownloadManager;
 using translate::TranslateRankerFeatures;
 using translate::TranslatePrefs;
@@ -199,15 +200,17 @@ TEST_F(TranslateRankerImplTest, DisabledByDefault) {
   auto ranker = GetRankerForTest(0.5);
   EXPECT_FALSE(ranker->IsQueryEnabled());
   EXPECT_FALSE(ranker->IsEnforcementEnabled());
+  EXPECT_FALSE(ranker->IsDecisionOverrideEnabled());
   EXPECT_TRUE(ranker->IsLoggingEnabled());
 }
 
 TEST_F(TranslateRankerImplTest, ExplicitlyDisabled) {
   InitFeatures({}, {kTranslateRankerQuery, kTranslateRankerEnforcement,
-                    kTranslateRankerLogging});
+                    kTranslateRankerLogging, kTranslateRankerDecisionOverride});
   auto ranker = GetRankerForTest(0.5);
   EXPECT_FALSE(ranker->IsQueryEnabled());
   EXPECT_FALSE(ranker->IsEnforcementEnabled());
+  EXPECT_FALSE(ranker->IsDecisionOverrideEnabled());
   EXPECT_FALSE(ranker->IsLoggingEnabled());
 }
 
@@ -216,6 +219,7 @@ TEST_F(TranslateRankerImplTest, EnableQuery) {
   auto ranker = GetRankerForTest(0.5);
   EXPECT_TRUE(ranker->IsQueryEnabled());
   EXPECT_FALSE(ranker->IsEnforcementEnabled());
+  EXPECT_FALSE(ranker->IsDecisionOverrideEnabled());
   EXPECT_TRUE(ranker->IsLoggingEnabled());
 }
 
@@ -224,6 +228,7 @@ TEST_F(TranslateRankerImplTest, EnableEnforcement) {
   auto ranker = GetRankerForTest(0.5);
   EXPECT_FALSE(ranker->IsQueryEnabled());
   EXPECT_TRUE(ranker->IsEnforcementEnabled());
+  EXPECT_FALSE(ranker->IsDecisionOverrideEnabled());
   EXPECT_TRUE(ranker->IsLoggingEnabled());
 }
 
@@ -232,6 +237,16 @@ TEST_F(TranslateRankerImplTest, EnableQueryAndEnforcement) {
   auto ranker = GetRankerForTest(0.5);
   EXPECT_TRUE(ranker->IsQueryEnabled());
   EXPECT_TRUE(ranker->IsEnforcementEnabled());
+  EXPECT_FALSE(ranker->IsDecisionOverrideEnabled());
+  EXPECT_TRUE(ranker->IsLoggingEnabled());
+}
+
+TEST_F(TranslateRankerImplTest, EnableDecisionOverride) {
+  InitFeatures({kTranslateRankerDecisionOverride}, {});
+  auto ranker = GetRankerForTest(0.5);
+  EXPECT_FALSE(ranker->IsQueryEnabled());
+  EXPECT_FALSE(ranker->IsEnforcementEnabled());
+  EXPECT_TRUE(ranker->IsDecisionOverrideEnabled());
   EXPECT_TRUE(ranker->IsLoggingEnabled());
 }
 
@@ -240,6 +255,7 @@ TEST_F(TranslateRankerImplTest, EnableLogging) {
   auto ranker = GetRankerForTest(0.5);
   EXPECT_FALSE(ranker->IsQueryEnabled());
   EXPECT_FALSE(ranker->IsEnforcementEnabled());
+  EXPECT_FALSE(ranker->IsDecisionOverrideEnabled());
   EXPECT_TRUE(ranker->IsLoggingEnabled());
 }
 
@@ -248,16 +264,18 @@ TEST_F(TranslateRankerImplTest, DisableLogging) {
   auto ranker = GetRankerForTest(0.5);
   EXPECT_FALSE(ranker->IsQueryEnabled());
   EXPECT_FALSE(ranker->IsEnforcementEnabled());
+  EXPECT_FALSE(ranker->IsDecisionOverrideEnabled());
   EXPECT_FALSE(ranker->IsLoggingEnabled());
 }
 
 TEST_F(TranslateRankerImplTest, EnableAll) {
   InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement,
-                kTranslateRankerLogging},
+                kTranslateRankerLogging, kTranslateRankerDecisionOverride},
                {});
   auto ranker = GetRankerForTest(0.5);
   EXPECT_TRUE(ranker->IsQueryEnabled());
   EXPECT_TRUE(ranker->IsEnforcementEnabled());
+  EXPECT_TRUE(ranker->IsDecisionOverrideEnabled());
   EXPECT_TRUE(ranker->IsLoggingEnabled());
 }