Allow TranslateRanker to override decisions taken by heuristics.

chrome/browser/translate/chrome_translate_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/translate/chrome_translate_client.h"
 
 #include <vector>
 
 #include "base/logging.h"
 #include "base/path_service.h"
@@ skipping 202 matching lines @@
         step != translate::TRANSLATE_STEP_BEFORE_TRANSLATE,
         translate_manager_->GetWeakPtr(),
         InfoBarService::FromWebContents(web_contents()),
         web_contents()->GetBrowserContext()->IsOffTheRecord(), step,
         source_language, target_language, error_type, triggered_from_menu);
     return;
   }
 #endif
 
   // Bubble UI.
-  if (step == translate::TRANSLATE_STEP_BEFORE_TRANSLATE) {
-    // TODO(droger): Move this logic out of UI code.
-    GetLanguageState().SetTranslateEnabled(true);
-    // In the new UI, continue offering translation after the user navigates to
-    // another page.
-    if (!base::FeatureList::IsEnabled(translate::kTranslateUI2016Q2) &&
-        !GetLanguageState().HasLanguageChanged()) {
-      translate_manager_->RecordTranslateEvent(
-          metrics::TranslateEventProto::MATCHES_PREVIOUS_LANGUAGE);
-      return;
-    }
+  if (step == translate::TRANSLATE_STEP_BEFORE_TRANSLATE &&
+      translate_manager_->ShouldSuppressBubbleUI(triggered_from_menu,
+                                                 source_language)) {
+    return;
+  }

[groby-ooo-7-16, 2017/04/20 19:45:57]

Woohoo! Thank you! (Long term, I wonder if this needs to be unified with the
Infobar code, but that's def. out of scope)

 
-    if (!triggered_from_menu &&
-        GetTranslatePrefs()->IsTooOftenDenied(source_language)) {
-      translate_manager_->RecordTranslateEvent(
-          metrics::TranslateEventProto::LANGUAGE_DISABLED_BY_AUTO_BLACKLIST);
-      return;
-    }
-  }
   ShowTranslateBubbleResult result = ShowBubble(step, error_type);
   if (result != ShowTranslateBubbleResult::SUCCESS &&
       step == translate::TRANSLATE_STEP_BEFORE_TRANSLATE) {
     translate_manager_->RecordTranslateEvent(
         BubbleResultToTranslateEvent(result));
   }
 }
 
 translate::TranslateDriver* ChromeTranslateClient::GetTranslateDriver() {
   return &translate_driver_;
@@ skipping 124 matching lines @@
       return ShowTranslateBubbleResult::SUCCESS;
   }
 
   return TranslateBubbleFactory::Show(browser->window(), web_contents(), step,
                                       error_type);
 #else
   NOTREACHED();
   return ShowTranslateBubbleResult::SUCCESS;
 #endif
 }