Allow TranslateRanker to override decisions taken by heuristics.

components/translate/core/browser/translate_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/translate/core/browser/translate_manager.h"
 
 #include <map>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 213 matching lines @@
   InitTranslateEvent(language_code, target_lang, *translate_prefs);
 
   // Don't translate similar languages (ex: en-US to en).
   if (language_code == target_lang) {
     TranslateBrowserMetrics::ReportInitiationStatus(
         TranslateBrowserMetrics::INITIATION_STATUS_SIMILAR_LANGUAGES);
     return;
   }
 
   bool ranker_should_offer_translation = true;
   if (translate_ranker_->IsQueryEnabled() ||

[groby-ooo-7-16, 2017/04/10 20:52:47]

This is more and more ranker-related logic that moves into the manager. Can we
instead move all of this over to the ranker?

I.e. this spot here would be just.

    bool ranker_should_offer_translation =
translate_ranker_->ShouldOfferTranslation(translate_event_);

The same goes for other spots. 

[hamelphi, 2017/04/11 22:46:07]

Done.

-      translate_ranker_->IsEnforcementEnabled()) {
+      translate_ranker_->IsEnforcementEnabled() ||
+      translate_ranker_->IsDecisionOverrideEnabled()) {
     ranker_should_offer_translation = translate_ranker_->ShouldOfferTranslation(
         *translate_prefs, language_code, target_lang);
     translate_event_->set_ranker_request_timestamp_sec(
         (base::TimeTicks::Now() - base::TimeTicks()).InSeconds());
     translate_event_->set_ranker_version(translate_ranker_->GetModelVersion());
     translate_event_->set_ranker_response(
         ranker_should_offer_translation
             ? metrics::TranslateEventProto::SHOW
             : metrics::TranslateEventProto::DONT_SHOW);
   }
@@ skipping 62 matching lines @@
   }
 
   if (LanguageInULP(language_code)) {
     TranslateBrowserMetrics::ReportInitiationStatus(
         TranslateBrowserMetrics::INITIATION_STATUS_LANGUAGE_IN_ULP);
     RecordTranslateEvent(metrics::TranslateEventProto::LANGUAGE_IN_ULP);
     return;
   }
 
   if (!ranker_should_offer_translation &&
-      translate_ranker_->IsEnforcementEnabled()) {
+      (translate_ranker_->IsEnforcementEnabled() ||
+       translate_ranker_->IsDecisionOverrideEnabled())) {
     TranslateBrowserMetrics::ReportInitiationStatus(
         TranslateBrowserMetrics::INITIATION_STATUS_ABORTED_BY_RANKER);
     RecordTranslateEvent(metrics::TranslateEventProto::DISABLED_BY_RANKER);
     return;
   }
 
   TranslateBrowserMetrics::ReportInitiationStatus(
       TranslateBrowserMetrics::INITIATION_STATUS_SHOW_INFOBAR);
 
   // Prompts the user if they want the page translated.
@@ skipping 273 matching lines @@
 
 void TranslateManager::RecordTranslateEvent(int event_type) {
   DCHECK(metrics::TranslateEventProto::EventType_IsValid(event_type));
   translate_event_->set_event_type(
       static_cast<metrics::TranslateEventProto::EventType>(event_type));
   translate_event_->set_event_timestamp_sec(
       (base::TimeTicks::Now() - base::TimeTicks()).InSeconds());
   translate_ranker_->AddTranslateEvent(*translate_event_);
 }
 
+bool TranslateManager::ShouldOverrideDecision(int event_type) {
+  DCHECK(metrics::TranslateEventProto::EventType_IsValid(event_type));
+  if (translate_ranker_->IsDecisionOverrideEnabled()) {
+    translate_event_->add_decision_overrides(
+        static_cast<metrics::TranslateEventProto::EventType>(event_type));
+    DVLOG(3) << "Overriding decision of type: " << event_type;
+    return true;
+  } else {
+    RecordTranslateEvent(event_type);
+    return false;
+  }
+}
+
 }  // namespace translate