Allow TranslateRanker to override decisions taken by heuristics.

chrome/browser/translate/chrome_translate_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/translate/chrome_translate_client.h"
 
 #include <vector>
 
 #include "base/logging.h"
 #include "base/path_service.h"
@@ skipping 207 matching lines @@
     return;
   }
 #endif
 
   // Bubble UI.
   if (step == translate::TRANSLATE_STEP_BEFORE_TRANSLATE) {
     // TODO(droger): Move this logic out of UI code.
     GetLanguageState().SetTranslateEnabled(true);
     // In the new UI, continue offering translation after the user navigates to
     // another page.
     if (!base::FeatureList::IsEnabled(translate::kTranslateUI2016Q2) &&

[groby-ooo-7-16, 2017/04/10 20:52:47]

I _really_ would prefer if this logic could be moved out of the UI code. This
section is growing instead of shrinking.

[hamelphi, 2017/04/11 22:46:07]

I moved the logic to TranslateManager. Let me know what you think. I have not
written the unittest yet, but I am working on it.

[hamelphi, 2017/04/12 21:10:53]

Unittests done.

-        !GetLanguageState().HasLanguageChanged()) {
-      translate_manager_->RecordTranslateEvent(
-          metrics::TranslateEventProto::MATCHES_PREVIOUS_LANGUAGE);
+        !GetLanguageState().HasLanguageChanged() &&
+        !translate_manager_->ShouldOverrideDecision(
+            metrics::TranslateEventProto::MATCHES_PREVIOUS_LANGUAGE)) {
       return;
     }
+    if (!triggered_from_menu &&
+        GetTranslatePrefs()->IsTooOftenDenied(source_language) &&
+        !translate_manager_->ShouldOverrideDecision(
+            metrics::TranslateEventProto::LANGUAGE_DISABLED_BY_AUTO_BLACKLIST))
+      return;
+  }
 
-    if (!triggered_from_menu &&
-        GetTranslatePrefs()->IsTooOftenDenied(source_language)) {
-      translate_manager_->RecordTranslateEvent(
-          metrics::TranslateEventProto::LANGUAGE_DISABLED_BY_AUTO_BLACKLIST);
-      return;
-    }
-  }
   ShowTranslateBubbleResult result = ShowBubble(step, error_type);
   if (result != ShowTranslateBubbleResult::SUCCESS &&
       step == translate::TRANSLATE_STEP_BEFORE_TRANSLATE) {
     translate_manager_->RecordTranslateEvent(
         BubbleResultToTranslateEvent(result));
   }
 }
 
 translate::TranslateDriver* ChromeTranslateClient::GetTranslateDriver() {
   return &translate_driver_;
@@ skipping 124 matching lines @@
       return ShowTranslateBubbleResult::SUCCESS;
   }
 
   return TranslateBubbleFactory::Show(browser->window(), web_contents(), step,
                                       error_type);
 #else
   NOTREACHED();
   return ShowTranslateBubbleResult::SUCCESS;
 #endif
 }