Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: media/base/android/media_codec_util.h

Issue 2697643003: media: Clean up MediaCodecBridge and remove subclasses (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_codec_util.h
diff --git a/media/base/android/media_codec_util.h b/media/base/android/media_codec_util.h
index 3bf0e5377235f7a7a52613e01d4683620f5b19e8..f74856fb40cc93b07394c7d5c40c2b88e2d71c4c 100644
--- a/media/base/android/media_codec_util.h
+++ b/media/base/android/media_codec_util.h
@@ -13,6 +13,7 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "media/base/android/media_codec_direction.h"
+#include "media/base/audio_codecs.h"
#include "media/base/media_export.h"
#include "media/base/video_codecs.h"
@@ -22,26 +23,11 @@ namespace media {
class MediaCodecBridge;
-// Helper macro to skip the test if MediaCodecBridge isn't available.
-#define SKIP_TEST_IF_MEDIA_CODEC_BRIDGE_IS_NOT_AVAILABLE() \
- do { \
- if (!MediaCodecUtil::IsMediaCodecAvailable()) { \
- VLOG(0) << "Could not run test - not supported on device."; \
- return; \
- } \
- } while (0)
-
-// Helper macro to skip the test if VP8 decoding isn't supported.
-#define SKIP_TEST_IF_VP8_DECODER_IS_NOT_SUPPORTED() \
- do { \
- if (!MediaCodecUtil::IsVp8DecoderAvailable()) { \
- VLOG(0) << "Could not run test - not supported on device."; \
- return; \
- } \
- } while (0)
-
class MEDIA_EXPORT MediaCodecUtil {
public:
+ static std::string CodecToAndroidMimeType(AudioCodec codec);
+ static std::string CodecToAndroidMimeType(VideoCodec codec);
+
// Returns true if MediaCodec is available on the device.
// All other static methods check IsAvailable() internally. There's no need
// to check IsAvailable() explicitly before calling them.
@@ -50,9 +36,9 @@ class MEDIA_EXPORT MediaCodecUtil {
// Returns true if MediaCodec.setParameters() is available on the device.
static bool SupportsSetParameters();
- // Returns whether MediaCodecBridge has a decoder that |is_secure| and can
- // decode |codec| type.
- static bool CanDecode(const std::string& codec, bool is_secure);
+ // Returns whether if it's possible to create a MediaCodec for the given
+ // mime type and secureness.
+ static bool CanDecode(const std::string& mime_type, bool is_secure);
// Returns a vector of supported codecs profiles and levels.
static bool AddSupportedCodecProfileLevels(
@@ -65,7 +51,7 @@ class MEDIA_EXPORT MediaCodecUtil {
// Returns true if |mime_type| is known to be unaccelerated (i.e. backed by a
// software codec instead of a hardware one).
- static bool IsKnownUnaccelerated(const std::string& mime_type,
+ static bool IsKnownUnaccelerated(VideoCodec codec,
MediaCodecDirection direction);
// Test whether a URL contains "m3u8".

Powered by Google App Engine
This is Rietveld 408576698