Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 269763003: mark flaky GM tests as ignore-failure (Closed)

Created:
6 years, 7 months ago by epoger
Modified:
6 years, 7 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com, djsollen
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

mark flaky GM tests as ignore-failure followup to https://codereview.chromium.org/265043002 ('commit GM actuals as expectations for all tests, marking them as unreviewed') BUG=skia:2332 NOTREECHECKS=True NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=14546

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
epoger
Only one new failure since I committed those 6000+ baselines. All Test-* bots that compare ...
6 years, 7 months ago (2014-05-02 18:15:21 UTC) #1
epoger
As noted in here, I'm waiting for the last two Android Test-* bots to process ...
6 years, 7 months ago (2014-05-02 18:16:44 UTC) #2
epoger
PTAL. Just this one test is flaky, and I think it's been flaky for a ...
6 years, 7 months ago (2014-05-02 20:19:48 UTC) #3
djsollen
lgtm. This test has been flaky all week.
6 years, 7 months ago (2014-05-02 20:23:25 UTC) #4
epoger
The CQ bit was checked by epoger@google.com
6 years, 7 months ago (2014-05-02 20:25:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/269763003/1
6 years, 7 months ago (2014-05-02 20:25:49 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 20:26:03 UTC) #7
Message was sent while issue was closed.
Change committed as 14546

Powered by Google App Engine
This is Rietveld 408576698