Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: ios/chrome/common/BUILD.gn

Issue 2697613003: Convert ios/chrome/commong/block_unittest.mm to ARC. (Closed)
Patch Set: Duplicate the test for ARC & non-ARC. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/chrome/common/block_unittest.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/ios/ios_sdk.gni") 6 import("//build/config/ios/ios_sdk.gni")
7 7
8 source_set("common") { 8 source_set("common") {
9 configs += [ "//build/config/compiler:enable_arc" ] 9 configs += [ "//build/config/compiler:enable_arc" ]
10 sources = [ 10 sources = [
(...skipping 12 matching lines...) Expand all
23 "//components/version_info", 23 "//components/version_info",
24 "//ios/chrome/common/app_group:main_app", 24 "//ios/chrome/common/app_group:main_app",
25 "//ios/chrome/common/physical_web", 25 "//ios/chrome/common/physical_web",
26 "//net", 26 "//net",
27 "//url", 27 "//url",
28 ] 28 ]
29 29
30 libs = [ "QuartzCore.framework" ] 30 libs = [ "QuartzCore.framework" ]
31 } 31 }
32 32
33 source_set("noarc_unit_tests") { 33 source_set("unit_tests") {
34 testonly = true 34 testonly = true
35 sources = [ 35 sources = [
36 "block_unittest.mm", 36 "block_unittest.mm",
37 ]
38 deps = [
39 ":common",
40 "//base",
41 "//testing/gtest",
42 ]
43 }
44
45 source_set("unit_tests") {
46 configs += [ "//build/config/compiler:enable_arc" ]
47 testonly = true
48 sources = [
49 "ns_regular_expression_unittest.mm", 37 "ns_regular_expression_unittest.mm",
50 "string_util_unittest.mm", 38 "string_util_unittest.mm",
51 "x_callback_url_unittest.cc", 39 "x_callback_url_unittest.cc",
52 ] 40 ]
53 deps = [ 41 deps = [
54 ":common", 42 ":common",
55 ":noarc_unit_tests", 43 ":noarc_unit_tests",
56 "//base", 44 "//base",
57 "//testing/gtest", 45 "//testing/gtest",
58 ] 46 ]
47 configs += [ "//build/config/compiler:enable_arc" ]
48 }
49
50 # The block_unittest.mm has been duplicated during the migration of iOS code
51 # to ARC (see crbug.com/624363). As this test checks the interaction of C++
52 # objects and Objective-C blocks, it is necessary to keep two version of the
53 # test compiled with and without ARC. Remove this file when the conversion to
54 # ARC is complete.
55 source_set("noarc_unit_tests") {
56 visibility = [ ":unit_tests" ]
57 testonly = true
58 sources = [
59 "noarc_block_unittest.mm",
60 ]
61 deps = [
62 ":common",
63 "//base",
64 "//testing/gtest",
65 ]
59 } 66 }
60 67
61 buildflag_header("ios_app_bundle_id_prefix_header") { 68 buildflag_header("ios_app_bundle_id_prefix_header") {
62 header = "ios_app_bundle_id_prefix.h" 69 header = "ios_app_bundle_id_prefix.h"
63 flags = [ "IOS_APP_BUNDLE_ID_PREFIX=\"$ios_app_bundle_id_prefix\"" ] 70 flags = [ "IOS_APP_BUNDLE_ID_PREFIX=\"$ios_app_bundle_id_prefix\"" ]
64 } 71 }
OLDNEW
« no previous file with comments | « no previous file | ios/chrome/common/block_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698