Allow to specify analysis-options to the analyzer step in package:testing, and

Allow to specify analysis-options to the analyzer step in package:testing, and
use it in pkg/front_end

BUG=
R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/884f0acf8d88850bb8c2cf47446a1e63d3f3d156

[Siggi Cherem (dart-lang), 2017-02-15 22:56:14]

sigmund@google.com changed reviewers:
+ ahe@google.com

[Siggi Cherem (dart-lang), 2017-02-15 22:56:16]

https://codereview.chromium.org/2697603009/diff/1/pkg/testing/lib/src/analyze...
File pkg/testing/lib/src/analyze.dart (left):

https://codereview.chromium.org/2697603009/diff/1/pkg/testing/lib/src/analyze...
pkg/testing/lib/src/analyze.dart:138: if (diagnostic.code ==
"DEPRECATED_MEMBER_USE") continue;
this one is no longer needed because the .analysis_options hides them

https://codereview.chromium.org/2697603009/diff/1/pkg/testing/lib/src/analyze...
pkg/testing/lib/src/analyze.dart:139: if (diagnostic.code == "MISSING_RETURN")
continue;
none left in fasta

https://codereview.chromium.org/2697603009/diff/1/pkg/testing/lib/src/analyze...
pkg/testing/lib/src/analyze.dart:140: if (diagnostic.code == "UNNECESSARY_CAST")
continue;
none see in fasta

https://codereview.chromium.org/2697603009/diff/1/pkg/testing/lib/src/run_tes...
File pkg/testing/lib/src/run_tests.dart (right):

https://codereview.chromium.org/2697603009/diff/1/pkg/testing/lib/src/run_tes...
pkg/testing/lib/src/run_tests.dart:118: "${candiates.map((file) =>
file.path).join('\n  ')}");
technically this is another case of a covariant override, but for this use case
it seemed that removing the type was fine.

This got pulled in when running analyzer tests in strong mode on fasta (it gets
pulled in from the tests in the test folder)

[ahe, 2017-02-16 12:22:09]

lgtm

Thank you, Siggi!

I think something is wrong with the logic for missing returns, but that's thing
for another day.

[Siggi Cherem (dart-lang), 2017-02-16 18:38:58]

Description was changed from

==========
Allow to specify analysis-options to the analyzer step in package:testing, and
use it in pkg/front_end

BUG=
==========

to

==========
Allow to specify analysis-options to the analyzer step in package:testing, and
use it in pkg/front_end

BUG=
R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/884f0acf8d88850bb8c2cf47446a1e63d3f3d156
==========

[Siggi Cherem (dart-lang), 2017-02-16 18:38:59]

Committed patchset #1 (id:1) manually as
884f0acf8d88850bb8c2cf47446a1e63d3f3d156 (presubmit successful).