Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js

Issue 2697603006: DevTools: Fix an exception on adding watch expression. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 615 matching lines...) Expand 10 before | Expand all | Expand 10 after
626 if (typeof this._title === 'string') 626 if (typeof this._title === 'string')
627 return this._title; 627 return this._title;
628 return this._title.textContent; 628 return this._title.textContent;
629 } 629 }
630 630
631 /** 631 /**
632 * @param {!UI.InplaceEditor.Config} editingConfig 632 * @param {!UI.InplaceEditor.Config} editingConfig
633 */ 633 */
634 startEditingTitle(editingConfig) { 634 startEditingTitle(editingConfig) {
635 UI.InplaceEditor.startEditing(this._titleElement, editingConfig); 635 UI.InplaceEditor.startEditing(this._titleElement, editingConfig);
636 this.treeOutline._shadowRoot.getSelection().setBaseAndExtent(this._titleElem ent, 0, this._titleElement, 1); 636 this.treeOutline._shadowRoot.getSelection().selectAllChildren(this._titleEle ment);
637 } 637 }
638 638
639 /** 639 /**
640 * @param {!Array<!UI.Icon>} icons 640 * @param {!Array<!UI.Icon>} icons
641 */ 641 */
642 setLeadingIcons(icons) { 642 setLeadingIcons(icons) {
643 if (!this._leadingIconsElement && !icons.length) 643 if (!this._leadingIconsElement && !icons.length)
644 return; 644 return;
645 if (!this._leadingIconsElement) { 645 if (!this._leadingIconsElement) {
646 this._leadingIconsElement = createElementWithClass('div', 'leading-icons') ; 646 this._leadingIconsElement = createElementWithClass('div', 'leading-icons') ;
(...skipping 568 matching lines...) Expand 10 before | Expand all | Expand 10 after
1215 UI.TreeElement._ArrowToggleWidth = 10; 1215 UI.TreeElement._ArrowToggleWidth = 10;
1216 1216
1217 (function() { 1217 (function() {
1218 var img = new Image(); 1218 var img = new Image();
1219 if (window.devicePixelRatio > 1) 1219 if (window.devicePixelRatio > 1)
1220 img.src = 'Images/treeoutlineTriangles_2x.png'; 1220 img.src = 'Images/treeoutlineTriangles_2x.png';
1221 else 1221 else
1222 img.src = 'Images/treeoutlineTriangles.png'; 1222 img.src = 'Images/treeoutlineTriangles.png';
1223 UI.TreeElement._imagePreload = img; 1223 UI.TreeElement._imagePreload = img;
1224 })(); 1224 })();
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698