Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/accessibility/ARIAAttributesView.js

Issue 2697603006: DevTools: Fix an exception on adding watch expression. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 Accessibility.ARIAAttributesPane = class extends Accessibility.AccessibilitySubP ane { 7 Accessibility.ARIAAttributesPane = class extends Accessibility.AccessibilitySubP ane {
8 constructor() { 8 constructor() {
9 super(Common.UIString('ARIA Attributes')); 9 super(Common.UIString('ARIA Attributes'));
10 10
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 this._editingCommitted(text, previousContent); 129 this._editingCommitted(text, previousContent);
130 } 130 }
131 131
132 this._prompt = new Accessibility.ARIAAttributesPane.ARIAAttributePrompt( 132 this._prompt = new Accessibility.ARIAAttributesPane.ARIAAttributePrompt(
133 Accessibility.ariaMetadata().valuesForProperty(this._nameElement.textCon tent), this); 133 Accessibility.ariaMetadata().valuesForProperty(this._nameElement.textCon tent), this);
134 this._prompt.setAutocompletionTimeout(0); 134 this._prompt.setAutocompletionTimeout(0);
135 var proxyElement = this._prompt.attachAndStartEditing(valueElement, blurList ener.bind(this, previousContent)); 135 var proxyElement = this._prompt.attachAndStartEditing(valueElement, blurList ener.bind(this, previousContent));
136 136
137 proxyElement.addEventListener('keydown', this._editingValueKeyDown.bind(this , previousContent), false); 137 proxyElement.addEventListener('keydown', this._editingValueKeyDown.bind(this , previousContent), false);
138 138
139 valueElement.getComponentSelection().setBaseAndExtent(valueElement, 0, value Element, 1); 139 valueElement.getComponentSelection().selectAllChildren(valueElement);
140 } 140 }
141 141
142 _removePrompt() { 142 _removePrompt() {
143 if (!this._prompt) 143 if (!this._prompt)
144 return; 144 return;
145 this._prompt.detach(); 145 this._prompt.detach();
146 delete this._prompt; 146 delete this._prompt;
147 } 147 }
148 148
149 /** 149 /**
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 'aria-readonly', 247 'aria-readonly',
248 'aria-relevant', 248 'aria-relevant',
249 'aria-required', 249 'aria-required',
250 'aria-setsize', 250 'aria-setsize',
251 'aria-sort', 251 'aria-sort',
252 'aria-valuemax', 252 'aria-valuemax',
253 'aria-valuemin', 253 'aria-valuemin',
254 'aria-valuenow', 254 'aria-valuenow',
255 'aria-valuetext', 255 'aria-valuetext',
256 ]; 256 ];
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698