Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Issue 2697603005: Check the type of a map entry before using it (issue 28756) (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check the type of a map entry before using it (issue 28756) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/7993dac4f18fb2540a2444dc06a5b86b82835006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 10 months ago (2017-02-14 20:55:21 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-02-14 20:55:58 UTC) #3
Brian Wilkerson
3 years, 10 months ago (2017-02-14 20:58:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7993dac4f18fb2540a2444dc06a5b86b82835006 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698