Reland [typedarrays] move %TypedArray%.prototype.copyWithin to C++

src/js/array.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function(global, utils, extrasUtils) {
 
 "use strict";
 
 %CheckIsBootstrapping();
 
@@ skipping 1252 matching lines @@
 
   // Pull out the length so that side effects are visible before the
   // callback function is checked.
   var array = TO_OBJECT(this);
   var length = TO_LENGTH(array.length);
   return InnerArrayReduceRight(callback, current, array, length,
                                arguments.length);
 }
 
 
-function InnerArrayCopyWithin(target, start, end, array, length) {
+// ES6 draft 03-17-15, section 22.1.3.3

[Camillo Bruni, 2017/02/15 13:36:28]

nit: please use sec reference instead of the (possibly changing) section numbers

[caitp, 2017/02/15 13:51:27]

Done.

+function ArrayCopyWithin(target, start, end) {
+  CHECK_OBJECT_COERCIBLE(this, "Array.prototype.copyWithin");
+
+  var array = TO_OBJECT(this);
+  var length = TO_LENGTH(array.length);
+
   target = TO_INTEGER(target);
   var to;
   if (target < 0) {
     to = MaxSimple(length + target, 0);
   } else {
     to = MinSimple(target, length);
   }
 
   start = TO_INTEGER(start);
   var from;
@@ skipping 27 matching lines @@
     }
     from = from + direction;
     to = to + direction;
     count--;
   }
 
   return array;
 }
 
 
-// ES6 draft 03-17-15, section 22.1.3.3
-function ArrayCopyWithin(target, start, end) {
-  CHECK_OBJECT_COERCIBLE(this, "Array.prototype.copyWithin");
-
-  var array = TO_OBJECT(this);
-  var length = TO_LENGTH(array.length);
-
-  return InnerArrayCopyWithin(target, start, end, array, length);
-}
-
-
 function InnerArrayFind(predicate, thisArg, array, length) {
   if (!IS_CALLABLE(predicate)) {
     throw %make_type_error(kCalledNonCallable, predicate);
   }
 
   for (var i = 0; i < length; i++) {
     var element = array[i];
     if (%_Call(predicate, thisArg, element, i, array)) {
       return element;
     }
@@ skipping 276 matching lines @@
 
 // -------------------------------------------------------------------
 // Exports
 
 utils.Export(function(to) {
   to.ArrayFrom = ArrayFrom;
   to.ArrayJoin = ArrayJoin;
   to.ArrayPush = ArrayPush;
   to.ArrayToString = ArrayToString;
   to.ArrayValues = IteratorFunctions.values,
-  to.InnerArrayCopyWithin = InnerArrayCopyWithin;
   to.InnerArrayEvery = InnerArrayEvery;
   to.InnerArrayFill = InnerArrayFill;
   to.InnerArrayFilter = InnerArrayFilter;
   to.InnerArrayFind = InnerArrayFind;
   to.InnerArrayFindIndex = InnerArrayFindIndex;
   to.InnerArrayForEach = InnerArrayForEach;
   to.InnerArrayJoin = InnerArrayJoin;
   to.InnerArrayLastIndexOf = InnerArrayLastIndexOf;
   to.InnerArrayReduce = InnerArrayReduce;
   to.InnerArrayReduceRight = InnerArrayReduceRight;
@@ skipping 10 matching lines @@
   "array_pop", ArrayPop,
   "array_push", ArrayPush,
   "array_shift", ArrayShift,
   "array_splice", ArraySplice,
   "array_slice", ArraySlice,
   "array_unshift", ArrayUnshift,
   "array_values_iterator", IteratorFunctions.values,
 ]);
 
 });