third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp - Issue 2697543003: Remove ToEventTarget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

Issue 2697543003: Remove ToEventTarget (Closed)

Patch Set: Code review changes Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_types.py ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

index 794dd9f5987f529e39d1cf3f9438099e4d8db718..b1dda0b237a5836f5bf1ad68baff4601cccc679b 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

@@ -234,7 +234,7 @@ void V8TestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value

if (eventTargetMemberValue.IsEmpty() || eventTargetMemberValue->IsUndefined()) {

// Do nothing.

} else {

- EventTarget* eventTargetMember = toEventTarget(isolate, eventTargetMemberValue);

+ EventTarget* eventTargetMember = V8EventTarget::toImplWithTypeCheck(isolate, eventTargetMemberValue);

if (!eventTargetMember) {

exceptionState.throwTypeError("member eventTargetMember is not of type EventTarget.");

return;