Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: ui/views/accessibility/ax_widget_obj_wrapper.cc

Issue 2697533003: Fix crash in widget destruction (Closed)
Patch Set: fix mac Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/accessibility/native_view_accessibility_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/accessibility/ax_widget_obj_wrapper.cc
diff --git a/ui/views/accessibility/ax_widget_obj_wrapper.cc b/ui/views/accessibility/ax_widget_obj_wrapper.cc
index 70307b919d3e93b1d60cbc41593722767c4d1adf..2d96f8c9400ae7c5aef7beb37385384395b92871 100644
--- a/ui/views/accessibility/ax_widget_obj_wrapper.cc
+++ b/ui/views/accessibility/ax_widget_obj_wrapper.cc
@@ -32,8 +32,10 @@ AXAuraObjWrapper* AXWidgetObjWrapper::GetParent() {
void AXWidgetObjWrapper::GetChildren(
std::vector<AXAuraObjWrapper*>* out_children) {
- if (!widget_->IsVisible() || !widget_->GetRootView()->visible())
+ if (!widget_->IsVisible() || !widget_->GetRootView() ||
+ !widget_->GetRootView()->visible()) {
return;
+ }
out_children->push_back(
AXAuraObjCache::GetInstance()->GetOrCreate(widget_->GetRootView()));
« no previous file with comments | « no previous file | ui/views/accessibility/native_view_accessibility_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698