Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/body_builder.dart

Issue 2697523002: Add accessor for getting target-specific constructor. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/builder/library_builder.dart ('k') | pkg/front_end/lib/src/fasta/loader.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/body_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
index 23f3a13d4882092cdbe9fa865752b00fe7df9590..a2357c1f0e2f243468e1271137e1a70a9301ca25 100644
--- a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
@@ -2202,13 +2202,11 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
Expression buildCompileTimeError(error, [int charOffset = -1]) {
String message = new InputError(uri, charOffset, error).format();
print(message);
- // TODO(ahe): Use a method on TargetImplementation for looking up the
- // constructor.
- final Constructor constructor = coreTypes.getCoreClass(
- "dart:core", "_CompileTimeError").constructors.first;
- return new Throw(new ConstructorInvocation(
- constructor,
- new Arguments(<Expression>[new StringLiteral(message)])));
+ Builder constructor = library.loader.getCompileTimeError();
+ return new Throw(
+ buildStaticInvocation(constructor.target,
+ new Arguments(<Expression>[new StringLiteral(message)]),
+ isConst: false)); // TODO(ahe): Make this const.
}
Statement buildCompileTimeErrorStatement(error, [int charOffset = -1]) {
« no previous file with comments | « pkg/front_end/lib/src/fasta/builder/library_builder.dart ('k') | pkg/front_end/lib/src/fasta/loader.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698