Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/TaskExtrasPackerTest.java

Issue 2697493002: [Offline pages] Implementation of OfflineBackgroundTask using background_task_scheduler (Closed)
Patch Set: Addressing more feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/TaskExtrasPackerTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/TaskExtrasPackerTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/TaskExtrasPackerTest.java
index 75fd8963ea122596d4f15efacf355316ebafa3d2..67739e95fc423ba515245c73f7228afa7a5ff3f7 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/TaskExtrasPackerTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/TaskExtrasPackerTest.java
@@ -10,7 +10,6 @@ import static org.junit.Assert.assertNotSame;
import static org.junit.Assert.assertTrue;
import android.os.Bundle;
-import android.os.PersistableBundle;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -71,45 +70,4 @@ public class TaskExtrasPackerTest {
assertEquals(100, unpackedConditionsFromEmptyBundle.getMinimumBatteryPercentage());
assertTrue(unpackedConditionsFromEmptyBundle.requireUnmeteredNetwork());
}
-
- @Test
- @Feature({"OfflinePages"})
- public void testScheduledTimeExtra_API22() {
- PersistableBundle taskExtras = new PersistableBundle();
- long beforeMillis = System.currentTimeMillis();
- TaskExtrasPacker.packTimeInBundle(taskExtras);
- long afterMillis = System.currentTimeMillis();
- long scheduledTimeMillis = TaskExtrasPacker.unpackTimeFromBundle(taskExtras);
- assertTrue(scheduledTimeMillis >= beforeMillis);
- assertTrue(scheduledTimeMillis <= afterMillis);
- }
-
- @Test
- @Feature({"OfflinePages"})
- public void testTriggerConditionsExtra_API22() {
- PersistableBundle taskExtras = new PersistableBundle();
- TriggerConditions conditions1 = new TriggerConditions(true, 25, false);
- TaskExtrasPacker.packTriggerConditionsInBundle(taskExtras, conditions1);
- TriggerConditions unpackedConditions1 =
- TaskExtrasPacker.unpackTriggerConditionsFromBundle(taskExtras);
- assertEquals(conditions1, unpackedConditions1);
- assertNotSame(conditions1, unpackedConditions1);
-
- // Now verify overwriting bundle with different values.
- TriggerConditions conditions2 = new TriggerConditions(false, 50, true);
- TaskExtrasPacker.packTriggerConditionsInBundle(taskExtras, conditions2);
- assertEquals(conditions2, TaskExtrasPacker.unpackTriggerConditionsFromBundle(taskExtras));
- }
-
- @Test
- @Feature({"OfflinePages"})
- public void testTriggerConditionsExtraDefaults_API22() {
- TriggerConditions unpackedConditionsFromEmptyBundle =
- TaskExtrasPacker.unpackTriggerConditionsFromBundle(new PersistableBundle());
-
- // Verify conservative defaults:
- assertTrue(unpackedConditionsFromEmptyBundle.requirePowerConnected());
- assertEquals(100, unpackedConditionsFromEmptyBundle.getMinimumBatteryPercentage());
- assertTrue(unpackedConditionsFromEmptyBundle.requireUnmeteredNetwork());
- }
}

Powered by Google App Engine
This is Rietveld 408576698