Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: components/content_settings/core/browser/host_content_settings_map.cc

Issue 2697473002: Remove last usage functions from HostContentSettingsMap and clean up prefs (Closed)
Patch Set: fix up unit test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/host_content_settings_map.cc
diff --git a/components/content_settings/core/browser/host_content_settings_map.cc b/components/content_settings/core/browser/host_content_settings_map.cc
index 4ebb241f3843046d1966fcd6115e62ae5751605d..4f263c025e8bfad4293d589bd691855322ade68b 100644
--- a/components/content_settings/core/browser/host_content_settings_map.cc
+++ b/components/content_settings/core/browser/host_content_settings_map.cc
@@ -464,11 +464,6 @@ void HostContentSettingsMap::SetContentSettingCustomScope(
ContentSetting setting) {
DCHECK(content_settings::ContentSettingsRegistry::GetInstance()->Get(
content_type));
- if (setting == CONTENT_SETTING_ALLOW &&
- (content_type == CONTENT_SETTINGS_TYPE_GEOLOCATION ||
- content_type == CONTENT_SETTINGS_TYPE_NOTIFICATIONS)) {
- UpdateLastUsageByPattern(primary_pattern, secondary_pattern, content_type);
- }
std::unique_ptr<base::Value> value;
// A value of CONTENT_SETTING_DEFAULT implies deleting the content setting.
@@ -640,63 +635,6 @@ void HostContentSettingsMap::RecordExceptionMetrics() {
}
}
-ContentSetting HostContentSettingsMap::GetContentSettingAndMaybeUpdateLastUsage(
- const GURL& primary_url,
- const GURL& secondary_url,
- ContentSettingsType content_type,
- const std::string& resource_identifier) {
- DCHECK(thread_checker_.CalledOnValidThread());
-
- ContentSetting setting = GetContentSetting(
- primary_url, secondary_url, content_type, resource_identifier);
- if (setting == CONTENT_SETTING_ALLOW) {
- UpdateLastUsageByPattern(
- ContentSettingsPattern::FromURLNoWildcard(primary_url),
- ContentSettingsPattern::FromURLNoWildcard(secondary_url),
- content_type);
- }
- return setting;
-}
-
-void HostContentSettingsMap::UpdateLastUsage(const GURL& primary_url,
- const GURL& secondary_url,
- ContentSettingsType content_type) {
- UpdateLastUsageByPattern(
- ContentSettingsPattern::FromURLNoWildcard(primary_url),
- ContentSettingsPattern::FromURLNoWildcard(secondary_url),
- content_type);
-}
-
-void HostContentSettingsMap::UpdateLastUsageByPattern(
- const ContentSettingsPattern& primary_pattern,
- const ContentSettingsPattern& secondary_pattern,
- ContentSettingsType content_type) {
- UsedContentSettingsProviders();
-
- pref_provider_->UpdateLastUsage(
- primary_pattern, secondary_pattern, content_type);
-}
-
-base::Time HostContentSettingsMap::GetLastUsage(
- const GURL& primary_url,
- const GURL& secondary_url,
- ContentSettingsType content_type) {
- return GetLastUsageByPattern(
- ContentSettingsPattern::FromURLNoWildcard(primary_url),
- ContentSettingsPattern::FromURLNoWildcard(secondary_url),
- content_type);
-}
-
-base::Time HostContentSettingsMap::GetLastUsageByPattern(
- const ContentSettingsPattern& primary_pattern,
- const ContentSettingsPattern& secondary_pattern,
- ContentSettingsType content_type) {
- UsedContentSettingsProviders();
-
- return pref_provider_->GetLastUsage(
- primary_pattern, secondary_pattern, content_type);
-}
-
void HostContentSettingsMap::AddObserver(content_settings::Observer* observer) {
observers_.AddObserver(observer);
}
@@ -710,13 +648,6 @@ void HostContentSettingsMap::FlushLossyWebsiteSettings() {
prefs_->SchedulePendingLossyWrites();
}
-void HostContentSettingsMap::SetPrefClockForTesting(
- std::unique_ptr<base::Clock> clock) {
- UsedContentSettingsProviders();
-
- pref_provider_->SetClockForTesting(std::move(clock));
-}
-
void HostContentSettingsMap::ClearSettingsForOneType(
ContentSettingsType content_type) {
UsedContentSettingsProviders();

Powered by Google App Engine
This is Rietveld 408576698