Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: components/content_settings/core/browser/content_settings_pref_provider.h

Issue 2697473002: Remove last usage functions from HostContentSettingsMap and clean up prefs (Closed)
Patch Set: fix up unit test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/content_settings_pref_provider.h
diff --git a/components/content_settings/core/browser/content_settings_pref_provider.h b/components/content_settings/core/browser/content_settings_pref_provider.h
index 0c08dfc165725f8435b6a27b148ce66cd63182ce..9f33e158f6e21b8ffafa08e48319ced333261fa0 100644
--- a/components/content_settings/core/browser/content_settings_pref_provider.h
+++ b/components/content_settings/core/browser/content_settings_pref_provider.h
@@ -18,10 +18,6 @@
class PrefService;
-namespace base {
-class Clock;
-}
-
namespace user_prefs {
class PrefRegistrySyncable;
}
@@ -57,20 +53,8 @@ class PrefProvider : public ObservableProvider {
void ClearPrefs();
- // Records the last time the given pattern has used a certain content setting.
- void UpdateLastUsage(const ContentSettingsPattern& primary_pattern,
- const ContentSettingsPattern& secondary_pattern,
- ContentSettingsType content_type);
-
- base::Time GetLastUsage(const ContentSettingsPattern& primary_pattern,
- const ContentSettingsPattern& secondary_pattern,
- ContentSettingsType content_type);
-
ContentSettingsPref* GetPref(ContentSettingsType type) const;
- // Gains ownership of |clock|.
- void SetClockForTesting(std::unique_ptr<base::Clock> clock);
-
private:
friend class DeadlockCheckerObserver; // For testing.
@@ -85,9 +69,6 @@ class PrefProvider : public ObservableProvider {
// Weak; owned by the Profile and reset in ShutdownOnUIThread.
PrefService* prefs_;
- // Can be set for testing.
- std::unique_ptr<base::Clock> clock_;
-
const bool is_incognito_;
PrefChangeRegistrar pref_change_registrar_;

Powered by Google App Engine
This is Rietveld 408576698