Remove last usage functions from HostContentSettingsMap and clean up prefs

components/content_settings/core/browser/content_settings_pref_provider.cc

Index: components/content_settings/core/browser/content_settings_pref_provider.cc
diff --git a/components/content_settings/core/browser/content_settings_pref_provider.cc b/components/content_settings/core/browser/content_settings_pref_provider.cc
index e544e4f004ab7b794e3833153de6863a4d872d80..62843a1f1c7634d80e1b28b80ce391cc65943989 100644
--- a/components/content_settings/core/browser/content_settings_pref_provider.cc
+++ b/components/content_settings/core/browser/content_settings_pref_provider.cc
@@ -15,8 +15,6 @@
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
-#include "base/time/clock.h"
-#include "base/time/default_clock.h"
 #include "components/content_settings/core/browser/content_settings_pref.h"
 #include "components/content_settings/core/browser/content_settings_rule.h"
 #include "components/content_settings/core/browser/content_settings_utils.h"
@@ -44,6 +42,7 @@ const char kObsoleteMouseLockExceptionsPref[] =
     "profile.content_settings.exceptions.mouselock";
 #endif  // !defined(OS_ANDROID)
 #endif  // !defined(OS_IOS)
+const char kObsoleteLastUsed[] = "last_used";
 
 }  // namespace
 
@@ -83,7 +82,6 @@ void PrefProvider::RegisterProfilePrefs(
 
 PrefProvider::PrefProvider(PrefService* prefs, bool incognito)
     : prefs_(prefs),
-      clock_(new base::DefaultClock()),
       is_incognito_(incognito) {
   DCHECK(prefs_);
   // Verify preferences version.
@@ -181,32 +179,12 @@ void PrefProvider::ClearPrefs() {
     pref.second->ClearPref();
 }
 
-void PrefProvider::UpdateLastUsage(
-    const ContentSettingsPattern& primary_pattern,
-    const ContentSettingsPattern& secondary_pattern,
-    ContentSettingsType content_type) {
-  GetPref(content_type)
-      ->UpdateLastUsage(primary_pattern, secondary_pattern, clock_.get());
-}
-
-base::Time PrefProvider::GetLastUsage(
-    const ContentSettingsPattern& primary_pattern,
-    const ContentSettingsPattern& secondary_pattern,
-    ContentSettingsType content_type) {
-  return GetPref(content_type)
-      ->GetLastUsage(primary_pattern, secondary_pattern);
-}
-
 ContentSettingsPref* PrefProvider::GetPref(ContentSettingsType type) const {
   auto it = content_settings_prefs_.find(type);
   DCHECK(it != content_settings_prefs_.end());
   return it->second.get();
 }
 
-void PrefProvider::SetClockForTesting(std::unique_ptr<base::Clock> clock) {
-  clock_ = std::move(clock);
-}
-
 void PrefProvider::Notify(
     const ContentSettingsPattern& primary_pattern,
     const ContentSettingsPattern& secondary_pattern,
@@ -250,6 +228,34 @@ void PrefProvider::DiscardObsoletePreferences() {
     prefs_->Set(permission_autoblocker_data_pref, *old_dict);
   prefs_->ClearPref(prompt_no_decision_count_pref);
 #endif  // !defined(OS_IOS)
+
+  // TODO(timloh): See crbug.com/691893. This removal code was added in M58,
+  // so is probably fine to remove in M60 or later.
+  for (const WebsiteSettingsInfo* info :
+       *WebsiteSettingsRegistry::GetInstance()) {
+    if (!prefs_->GetDictionary(info->pref_name()))
+      continue;
+
+    DictionaryPrefUpdate update(prefs_, info->pref_name());
+    base::DictionaryValue* all_settings = update.Get();
+    std::vector<std::string> values_to_clean;
+    for (base::DictionaryValue::Iterator i(*all_settings); !i.IsAtEnd();
+         i.Advance()) {
+      const base::DictionaryValue* pattern_settings = nullptr;
+      bool is_dictionary = i.value().GetAsDictionary(&pattern_settings);
+      DCHECK(is_dictionary);
+      if (pattern_settings->GetWithoutPathExpansion(kObsoleteLastUsed, nullptr))
+        values_to_clean.push_back(i.key());
+    }
+
+    for (auto key : values_to_clean) {

[Bernhard Bauer, 2017/02/14 13:38:27]

Use the actual type instead of auto.

[Timothy Loh, 2017/02/17 06:54:38]

Done.

+      base::DictionaryValue* pattern_settings = nullptr;
+      all_settings->GetDictionaryWithoutPathExpansion(key, &pattern_settings);
+      pattern_settings->RemoveWithoutPathExpansion(kObsoleteLastUsed, nullptr);
+      if (pattern_settings->empty())
+        all_settings->RemoveWithoutPathExpansion(key, nullptr);
+    }
+  }
 }
 
 }  // namespace content_settings