extensions/common/extension_utility_types.h - Issue 2697463002: Convert utility process extension Unpacker IPC to mojo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/common/extension_utility_types.h

Issue 2697463002: Convert utility process extension Unpacker IPC to mojo (Closed)

Patch Set: Comment-only change in response to review comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef EXTENSIONS_COMMON_EXTENSION_UTILITY_TYPES_H_

	6 #define EXTENSIONS_COMMON_EXTENSION_UTILITY_TYPES_H_

	7

	8 #include <tuple>

	9 #include <vector>

	10

	11 #include "base/files/file_path.h"

	12 #include "third_party/skia/include/core/SkBitmap.h"

	13 #include "ui/gfx/ipc/skia/gfx_skia_param_traits.h"
	Devlin 2017/03/08 16:22:24 needed? needed? Noel Gordon 2017/03/08 17:56:09 Not sure, will check this tomorrow. Show quoted text On 2017/03/08 16:22:24, Devlin wrote: > needed? Not sure, will check this tomorrow. Noel Gordon 2017/03/09 15:48:44 Yeap, needed. I added documentation to the .mojom Show quoted text On 2017/03/08 17:56:09, noel gordon wrote: > On 2017/03/08 16:22:24, Devlin wrote: > > needed? > > Not sure, will check this tomorrow. Yeap, needed. I added documentation to the .mojom about it, to do with writing decoded images during unpacking in some special file as a pickle of the DecodeImage type.
	14

	15 using DecodedImages = std::vector<std::tuple<SkBitmap, base::FilePath>>;

	16

	17 #endif // EXTENSIONS_COMMON_EXTENSION_UTILITY_TYPES_H_

OLD	NEW