Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: extensions/browser/sandboxed_unpacker_unittest.cc

Issue 2697463002: Convert utility process extension Unpacker IPC to mojo (Closed)
Patch Set: Comment-only change in response to review comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/sandboxed_unpacker.h"
Devlin 2017/03/08 16:22:24 ditto re orthogonal stylistic changes
Noel Gordon 2017/03/08 17:56:09 Yeah I started up the track of forward declaring m
6
5 #include "base/base64.h" 7 #include "base/base64.h"
6 #include "base/bind.h" 8 #include "base/bind.h"
7 #include "base/command_line.h" 9 #include "base/command_line.h"
8 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
9 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
10 #include "base/path_service.h" 12 #include "base/path_service.h"
11 #include "base/run_loop.h" 13 #include "base/run_loop.h"
12 #include "base/strings/string_util.h" 14 #include "base/strings/string_util.h"
13 #include "base/threading/thread_task_runner_handle.h" 15 #include "base/threading/thread_task_runner_handle.h"
14 #include "base/values.h" 16 #include "base/values.h"
15 #include "components/crx_file/id_util.h" 17 #include "components/crx_file/id_util.h"
16 #include "content/public/test/test_browser_thread_bundle.h" 18 #include "content/public/test/test_browser_thread_bundle.h"
17 #include "content/public/test/test_utils.h" 19 #include "content/public/test/test_utils.h"
18 #include "extensions/browser/extensions_test.h" 20 #include "extensions/browser/extensions_test.h"
19 #include "extensions/browser/sandboxed_unpacker.h"
20 #include "extensions/common/constants.h" 21 #include "extensions/common/constants.h"
21 #include "extensions/common/extension.h" 22 #include "extensions/common/extension.h"
22 #include "extensions/common/extension_paths.h" 23 #include "extensions/common/extension_paths.h"
23 #include "extensions/common/switches.h" 24 #include "extensions/common/switches.h"
24 #include "testing/gtest/include/gtest/gtest.h" 25 #include "testing/gtest/include/gtest/gtest.h"
25 #include "third_party/skia/include/core/SkBitmap.h" 26 #include "third_party/skia/include/core/SkBitmap.h"
26 #include "third_party/zlib/google/zip.h" 27 #include "third_party/zlib/google/zip.h"
27 28
28 namespace extensions { 29 namespace extensions {
29 30
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 EXPECT_EQ(base::string16(), GetInstallError()); 183 EXPECT_EQ(base::string16(), GetInstallError());
183 } 184 }
184 185
185 TEST_F(SandboxedUnpackerTest, SkipHashCheck) { 186 TEST_F(SandboxedUnpackerTest, SkipHashCheck) {
186 SetupUnpacker("good_l10n.crx", "badhash"); 187 SetupUnpacker("good_l10n.crx", "badhash");
187 // Check that there is no error message. 188 // Check that there is no error message.
188 EXPECT_EQ(base::string16(), GetInstallError()); 189 EXPECT_EQ(base::string16(), GetInstallError());
189 } 190 }
190 191
191 } // namespace extensions 192 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698