Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2697403005: Add script to run fasta as a benchmark (Closed)

Created:
3 years, 10 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 10 months ago
Reviewers:
Paul Berry, ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -0 lines) Patch
A pkg/front_end/tool/fasta_perf.dart View 1 chunk +298 lines, -0 lines 0 comments Download
A pkg/front_end/tool/fasta_perf_test.dart View 1 chunk +21 lines, -0 lines 0 comments Download
M pkg/pkg.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Siggi Cherem (dart-lang)
3 years, 10 months ago (2017-02-17 18:30:03 UTC) #5
Paul Berry
I'm not all that qualified to review this, but I don't see any obvious problems, ...
3 years, 10 months ago (2017-02-17 22:23:51 UTC) #6
Siggi Cherem (dart-lang)
Thanks Paul - I appreciate it.
3 years, 10 months ago (2017-02-17 22:26:42 UTC) #7
Siggi Cherem (dart-lang)
3 years, 10 months ago (2017-02-17 22:34:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:60001) manually as
04cf44d89c31a78c7f8c1e690de5a0c9892dc8e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698