third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html - Issue 2697403003: DevTools: "Delete File" in navigator should actually delete a file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

Issue 2697403003: DevTools: "Delete File" in navigator should actually delete a file (Closed)

Patch Set: address comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/persistence/filesystem-delete-file-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

index 27a1341f62a9258602d85af12e016308f4f12453..3b147c61c96bf33178de9ee7fd32db490547ff10 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

@@ -136,8 +136,8 @@ function test()

function onContentDumped()

{

- Snippets.scriptSnippetModel.project().deleteFile(uiSourceCode1.url());

- Snippets.scriptSnippetModel.project().deleteFile(uiSourceCode2.url());

+ Snippets.scriptSnippetModel.project().deleteFile(uiSourceCode1);

+ Snippets.scriptSnippetModel.project().deleteFile(uiSourceCode2);

Snippets.scriptSnippetModel.project().createFile("", null, "", step4.bind(this));

}

@@ -146,7 +146,7 @@ function test()

{

var uiSourceCode3 = uiSourceCode;

InspectorTest.addResult("Snippet3 created.");

- Snippets.scriptSnippetModel.project().deleteFile(uiSourceCode3.url());

+ Snippets.scriptSnippetModel.project().deleteFile(uiSourceCode3);

InspectorTest.addResult("Snippet3 deleted.");

InspectorTest.addResult("Number of uiSourceCodes in workspace: " + workspace.uiSourceCodes().filter(filterSnippet).length);