Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js

Issue 2697403003: DevTools: "Delete File" in navigator should actually delete a file (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 /** 535 /**
536 * @this {Persistence.FileSystemWorkspaceBinding.FileSystem} 536 * @this {Persistence.FileSystemWorkspaceBinding.FileSystem}
537 */ 537 */
538 function contentSet() { 538 function contentSet() {
539 callback(this._addFile(createFilePath)); 539 callback(this._addFile(createFilePath));
540 } 540 }
541 } 541 }
542 542
543 /** 543 /**
544 * @override 544 * @override
545 * @param {string} path 545 * @param {!Workspace.UISourceCode} uiSourceCode
546 */ 546 */
547 deleteFile(path) { 547 deleteFile(uiSourceCode) {
548 this._fileSystem.deleteFile(path); 548 var relativePath = this._filePathForUISourceCode(uiSourceCode);
549 this.removeUISourceCode(path); 549 this._fileSystem.deleteFile(relativePath);
550 this.removeUISourceCode(uiSourceCode.url());
550 } 551 }
551 552
552 /** 553 /**
553 * @override 554 * @override
554 */ 555 */
555 remove() { 556 remove() {
556 this._fileSystemWorkspaceBinding._isolatedFileSystemManager.removeFileSystem (this._fileSystem); 557 this._fileSystemWorkspaceBinding._isolatedFileSystemManager.removeFileSystem (this._fileSystem);
557 } 558 }
558 559
559 /** 560 /**
(...skipping 22 matching lines...) Expand all
582 uiSourceCode[Persistence.FileSystemWorkspaceBinding._metadata] = null; 583 uiSourceCode[Persistence.FileSystemWorkspaceBinding._metadata] = null;
583 uiSourceCode.checkContentUpdated(); 584 uiSourceCode.checkContentUpdated();
584 } 585 }
585 586
586 dispose() { 587 dispose() {
587 this.removeProject(); 588 this.removeProject();
588 } 589 }
589 }; 590 };
590 591
591 Persistence.FileSystemWorkspaceBinding._metadata = Symbol('FileSystemWorkspaceBi nding.Metadata'); 592 Persistence.FileSystemWorkspaceBinding._metadata = Symbol('FileSystemWorkspaceBi nding.Metadata');
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698