Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js

Issue 2697403003: DevTools: "Delete File" in navigator should actually delete a file (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 526 matching lines...) Expand 10 before | Expand all | Expand 10 after
537 */ 537 */
538 function contentSet() { 538 function contentSet() {
539 callback(this._addFile(createFilePath)); 539 callback(this._addFile(createFilePath));
540 } 540 }
541 } 541 }
542 542
543 /** 543 /**
544 * @override 544 * @override
545 * @param {string} path 545 * @param {string} path
546 */ 546 */
547 deleteFile(path) { 547 deleteFile(path) {
dgozman 2017/02/17 01:13:12 Let's pass the UISourceCode here instead.
lushnikov 2017/02/17 01:57:47 Done.
548 this._fileSystem.deleteFile(path); 548 var uiSourceCode = this.uiSourceCodeForURL(path);
549 if (!uiSourceCode)
550 return;
551 var relativePath = Persistence.FileSystemWorkspaceBinding.relativePath(uiSou rceCode).join('/');
dgozman 2017/02/17 01:13:12 this._filePathForUISourceCode
lushnikov 2017/02/17 01:57:47 Done.
552 this._fileSystem.deleteFile(relativePath);
549 this.removeUISourceCode(path); 553 this.removeUISourceCode(path);
550 } 554 }
551 555
552 /** 556 /**
553 * @override 557 * @override
554 */ 558 */
555 remove() { 559 remove() {
556 this._fileSystemWorkspaceBinding._isolatedFileSystemManager.removeFileSystem (this._fileSystem); 560 this._fileSystemWorkspaceBinding._isolatedFileSystemManager.removeFileSystem (this._fileSystem);
557 } 561 }
558 562
(...skipping 23 matching lines...) Expand all
582 uiSourceCode[Persistence.FileSystemWorkspaceBinding._metadata] = null; 586 uiSourceCode[Persistence.FileSystemWorkspaceBinding._metadata] = null;
583 uiSourceCode.checkContentUpdated(); 587 uiSourceCode.checkContentUpdated();
584 } 588 }
585 589
586 dispose() { 590 dispose() {
587 this.removeProject(); 591 this.removeProject();
588 } 592 }
589 }; 593 };
590 594
591 Persistence.FileSystemWorkspaceBinding._metadata = Symbol('FileSystemWorkspaceBi nding.Metadata'); 595 Persistence.FileSystemWorkspaceBinding._metadata = Symbol('FileSystemWorkspaceBi nding.Metadata');
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698