Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: extensions/renderer/api_bindings_system.cc

Issue 2697363003: [Extensions Bindings] Move request dispatch to APIRequestHandler (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api_bindings_system.cc
diff --git a/extensions/renderer/api_bindings_system.cc b/extensions/renderer/api_bindings_system.cc
index 76490c01c919c07b274a8ed9b2c33a21684626bc..b90483bcb1ae33ed74a0142f002f31784b217c19 100644
--- a/extensions/renderer/api_bindings_system.cc
+++ b/extensions/renderer/api_bindings_system.cc
@@ -15,17 +15,16 @@ APIBindingsSystem::APIBindingsSystem(
const binding::RunJSFunction& call_js,
const binding::RunJSFunctionSync& call_js_sync,
const GetAPISchemaMethod& get_api_schema,
- const APIBinding::SendRequestMethod& send_request,
+ const APIRequestHandler::SendRequestMethod& send_request,
const APIEventHandler::EventListenersChangedMethod& event_listeners_changed,
APILastError last_error)
: type_reference_map_(base::Bind(&APIBindingsSystem::InitializeType,
base::Unretained(this))),
- request_handler_(call_js, std::move(last_error)),
+ request_handler_(send_request, call_js, std::move(last_error)),
event_handler_(call_js, event_listeners_changed),
call_js_(call_js),
call_js_sync_(call_js_sync),
- get_api_schema_(get_api_schema),
- send_request_(send_request) {}
+ get_api_schema_(get_api_schema) {}
APIBindingsSystem::~APIBindingsSystem() {}
@@ -71,8 +70,8 @@ std::unique_ptr<APIBinding> APIBindingsSystem::CreateNewAPIBinding(
return base::MakeUnique<APIBinding>(
api_name, function_definitions, type_definitions, event_definitions,
- property_definitions, send_request_, std::move(hooks),
- &type_reference_map_, &request_handler_, &event_handler_);
+ property_definitions, std::move(hooks), &type_reference_map_,
+ &request_handler_, &event_handler_);
}
void APIBindingsSystem::InitializeType(const std::string& type_name) {

Powered by Google App Engine
This is Rietveld 408576698