OLD | NEW |
1 # Adding third_party Libraries | 1 # Adding third_party Libraries |
2 | 2 |
3 [TOC] | 3 [TOC] |
4 | 4 |
5 Using third party code can save time and is consistent with our values - no need | 5 Using third party code can save time and is consistent with our values - no need |
6 to reinvent the wheel! We put all code that isn't written by Chromium developers | 6 to reinvent the wheel! We put all code that isn't written by Chromium developers |
7 into src/third_party (even if you end up modifying just a few functions). We do | 7 into src/third_party (even if you end up modifying just a few functions). We do |
8 this to make it easy to track license compliance, security patches, and supply | 8 this to make it easy to track license compliance, security patches, and supply |
9 the right credit and attributions. It also makes it a lot easier for other | 9 the right credit and attributions. It also makes it a lot easier for other |
10 projects that embed our code to track what is Chromium licensed and what is | 10 projects that embed our code to track what is Chromium licensed and what is |
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
75 See the ["Odds n' Ends"](adding_to_third_party.md#Odds-n_Ends) Section below if | 75 See the ["Odds n' Ends"](adding_to_third_party.md#Odds-n_Ends) Section below if |
76 you run into any failures running these. | 76 you run into any failures running these. |
77 | 77 |
78 If the library will never be shipped as a part of Chrome (e.g. build-time tools, | 78 If the library will never be shipped as a part of Chrome (e.g. build-time tools, |
79 testing tools), make sure to set "License File" as "NOT_SHIPPED" so that the | 79 testing tools), make sure to set "License File" as "NOT_SHIPPED" so that the |
80 license is not included in about:credits page. | 80 license is not included in about:credits page. |
81 | 81 |
82 ### Modify DEPS | 82 ### Modify DEPS |
83 | 83 |
84 If the code is applicable and will be compiled on all supported Chromium | 84 If the code is applicable and will be compiled on all supported Chromium |
85 platforms (Windows, Mac, Linux, ChromeOS, iOS, Android), check it in to | 85 platforms (Windows, Mac, Linux, Chrome OS, iOS, Android), check it in to |
86 [src/third_party](http://src.chromium.org/viewvc/chrome/trunk/src/third_party/).
| 86 [src/third_party](http://src.chromium.org/viewvc/chrome/trunk/src/third_party/).
|
87 | 87 |
88 If the code is only applicable to certain platforms, check it in to | 88 If the code is only applicable to certain platforms, check it in to |
89 [src/third_party](http://src.chromium.org/viewvc/chrome/trunk/src/third_party/) | 89 [src/third_party](http://src.chromium.org/viewvc/chrome/trunk/src/third_party/) |
90 and add an entry to the | 90 and add an entry to the |
91 [DEPS](http://src.chromium.org/viewvc/chrome/trunk/src/DEPS) file that causes | 91 [DEPS](http://src.chromium.org/viewvc/chrome/trunk/src/DEPS) file that causes |
92 the code to be checked out from src/third_party into src/third_party by gclient. | 92 the code to be checked out from src/third_party into src/third_party by gclient. |
93 | 93 |
94 _Explanation: Checking it into src/third_party causes all developers to need to | 94 _Explanation: Checking it into src/third_party causes all developers to need to |
95 check out your code. This wastes disk space cause syncing to take longer for | 95 check out your code. This wastes disk space cause syncing to take longer for |
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
193 | 193 |
194 * Missing license file | 194 * Missing license file |
195 * Make sure that the license file is present. It should be called 'LICENSE', | 195 * Make sure that the license file is present. It should be called 'LICENSE', |
196 or otherwise README.chromium file must point to it explicitly. | 196 or otherwise README.chromium file must point to it explicitly. |
197 * The following files contain a third-party license but are not in a listed | 197 * The following files contain a third-party license but are not in a listed |
198 third-party directory... | 198 third-party directory... |
199 * Check if it's a false positive (e.g. 'copyright' word used in a string | 199 * Check if it's a false positive (e.g. 'copyright' word used in a string |
200 literal), if so, update | 200 literal), if so, update |
201 [src/tools/copyright_scanner/third_party_files_whitelist.txt](https://code
.google.com/p/chromium/codesearch#chromium/src/tools/copyright_scanner/third_par
ty_files_whitelist.txt) | 201 [src/tools/copyright_scanner/third_party_files_whitelist.txt](https://code
.google.com/p/chromium/codesearch#chromium/src/tools/copyright_scanner/third_par
ty_files_whitelist.txt) |
202 file. Otherwise, please move the code into third_party. | 202 file. Otherwise, please move the code into third_party. |
OLD | NEW |