Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2697323003: Begin running tests in TopLevelParserTest using the Fasta parser. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, ahe
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Begin running tests in TopLevelParserTest using the Fasta parser. Most tests currently fail due to methods that are not yet implemented in AstBuilder. These tests are annotated with "@failingTest". I will begin filling out the implementation of AstBuilder (and removing the "@failingTest" overrides) in follow-up CLs. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/7d0b31e32371b7d3f9aa2b43e75bd5259e97625a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1201 lines, -263 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 7 chunks +917 lines, -22 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 112 chunks +284 lines, -241 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 10 months ago (2017-02-16 21:11:04 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-02-16 21:13:35 UTC) #3
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-16 21:22:13 UTC) #4
Paul Berry
3 years, 10 months ago (2017-02-16 22:20:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d0b31e32371b7d3f9aa2b43e75bd5259e97625a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698