third_party/WebKit/LayoutTests/http/tests/worklet/import-on-detached-iframe.html - Issue 2697243003: Worklet: Avoid import() on a detached frame

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/worklet/import-on-detached-iframe.html

Issue 2697243003: Worklet: Avoid import() on a detached frame (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>Worklet: import() on a detached iframe</title>

	4 <body>

	5 </body>

	6 <script src="../resources/testharness.js"></script>

	7 <script src="../resources/testharnessreport.js"></script>

	8 <script>

	9

	10 function with_iframe(url) {

	11 return new Promise(resolve => {

	12 var frame = document.createElement('iframe');
	falken 2017/02/16 07:25:03 nit: let or const nit: let or const nhiroki 2017/02/16 07:33:07 Done. Show quoted text On 2017/02/16 07:25:03, falken wrote: > nit: let or const Done.
	13 frame.src = url;

	14 frame.onload = () => { resolve(frame); };

	15 document.body.appendChild(frame);

	16 add_completion_callback(() => frame.remove());
	falken 2017/02/16 07:25:03 nit: add_result_callback may be slightly cleaner i nit: add_result_callback may be slightly cleaner in case more tests are added to this file. If I understand correctly add_result_callback is invoked when this promise_test finishes, and add_completion_callback is invoked when all tests finish. nhiroki 2017/02/16 07:33:07 Yeah, it looks like add_result_callback is more pr Show quoted text On 2017/02/16 07:25:03, falken wrote: > nit: add_result_callback may be slightly cleaner in case more tests are added to > this file. If I understand correctly add_result_callback is invoked when this > promise_test finishes, and add_completion_callback is invoked when all tests > finish. Yeah, it looks like add_result_callback is more preferable here. Replaced.
	17 });

	18 }

	19

	20 promise_test(t => {

	21 const kFrameUrl = 'resources/blank.html';

	22 const kScriptUrl = 'resources/empty-worklet-script.js';

	23

	24 return with_iframe(kFrameUrl)

	25 .then(frame => {

	26 let worklet = frame.contentWindow.paintWorklet;

	27 frame.remove();

	28 return worklet.import(kScriptUrl);

	29 })

	30 .then(() => assert_unreached('import() should fail.'))

	31 .catch(e => assert_equals(e.name, 'InvalidStateError', e));

	32 }, 'import() on a detached iframe should be rejected.');

	33

	34 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/worklet/resources/blank.html » ('j') | no next file with comments »