Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 269723009: Add UI in Aura for distilling web pages and update Chrome Shell. (Closed)

Created:
6 years, 7 months ago by nyquist
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Add UI in Aura for distilling web pages and update Chrome Shell. For Aura, this CL hooks up a menu action for distilling the current web page. For Chrome Shell, this updates the call to use the new flow by using the current web page. Depends on: https://codereview.chromium.org/266073003/ BUG=361939 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273217

Patch Set 1 #

Patch Set 2 : Updated to use WebContents for ChromeShell #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Patch Set 5 : Removed usage of dom_distiller namespace #

Patch Set 6 : Rebased #

Patch Set 7 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/chrome_command_ids.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 3 4 5 6 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nyquist
sky: PTAL
6 years, 7 months ago (2014-05-20 20:08:12 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-20 20:55:57 UTC) #2
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 7 months ago (2014-05-28 08:05:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/269723009/110001
6 years, 7 months ago (2014-05-28 08:06:21 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 14:19:49 UTC) #5
Message was sent while issue was closed.
Change committed as 273217

Powered by Google App Engine
This is Rietveld 408576698