Add a WebWidget::paintCompositedDeprecated.

Add a WebWidget::paintCompositedDeprecated.

This method is implemented by WebViewImpl and paints a composited
WebViewImpl into a canvas using the legacy software mode mechanisms.

This will be called by RenderViewImpl::didTapMultipleTargets on android
only, and will replace the enum value of
ForceSoftwareRenderingAndIgnoreGPUResidentContent.

R=abarth, enne
BUG=251960
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173321

[enne (OOO), 2014-05-02 23:34:45]

https://codereview.chromium.org/269723008/diff/1/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/269723008/diff/1/Source/web/WebViewImpl.cpp#n...
Source/web/WebViewImpl.cpp:1810: void
WebViewImpl::paintCompositedDeprecated(WebCanvas* canvas, const WebRect& rect,
PaintOptions option)
Does this even compile? Looks like your definition has an extra arg here.

https://codereview.chromium.org/269723008/diff/1/Source/web/WebViewImpl.cpp#n...
Source/web/WebViewImpl.cpp:1821: double paintStart = currentTime();
This duplicated timing code makes me a little sad, but I'm mostly not sure that
it's worth keeping around anymore.

[danakj, 2014-05-02 23:36:07]

https://codereview.chromium.org/269723008/diff/1/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/269723008/diff/1/Source/web/WebViewImpl.cpp#n...
Source/web/WebViewImpl.cpp:1810: void
WebViewImpl::paintCompositedDeprecated(WebCanvas* canvas, const WebRect& rect,
PaintOptions option)
On 2014/05/02 23:34:45, enne wrote:
> Does this even compile? Looks like your definition has an extra arg here.

Oops, probly not, was going to let bots tell me :)

https://codereview.chromium.org/269723008/diff/1/Source/web/WebViewImpl.cpp#n...
Source/web/WebViewImpl.cpp:1821: double paintStart = currentTime();
On 2014/05/02 23:34:45, enne wrote:
> This duplicated timing code makes me a little sad, but I'm mostly not sure
that
> it's worth keeping around anymore.

I was going to make this call paint() but I want paint() to assert that we're
not composited.

[danakj, 2014-05-02 23:38:37]

Sorry for the bad patch, juggling too many CLs at once. This should be better
now, hopefully. It only adds the method to the API on ANDROID.

We probly dont need the UMA stats for this case, I've removed them.

[enne (OOO), 2014-05-02 23:41:56]

lgtm

[danakj, 2014-05-02 23:48:29]

On 2014/05/02 23:41:56, enne wrote:
> lgtm

Thanks!

abarth PTAL for owners and CQ? if you like it please.

[abarth-chromium, 2014-05-03 01:24:32]

lgtm

[commit-bot: I haz the power, 2014-05-03 01:24:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/269723008/40001

[commit-bot: I haz the power, 2014-05-03 01:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-03 01:57:56]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink

[danakj, 2014-05-05 16:00:34]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-05 16:00:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/269723008/60001

[danakj, 2014-05-05 16:01:13]

Using OS(ANDROID) in WebWidget.h didn't work, so make the method always there,
but only implenting it on WebViewImpl on OS(ANDROID)

[commit-bot: I haz the power, 2014-05-05 17:06:06]

Change committed as 173321