Issue 269723006: Add get_target_outputs function to GN

Issue 269723006: Add get_target_outputs function to GN (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
scottmg

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add get_target_outputs function to GN This function returns the outputs for a target that appeared previously in the same file. This is frequently needed for getting the files resulting from an action. The main operational change is that targets that are generated are stashed in a vector as we process a file and then dispatched once that file is finished, rather than being dispatched as-we-go. This way we can ask questions about the targets that appeared previously in the file. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268260

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 5

Patch Set 4 : review comments #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+406 lines, -12 lines)			Patch
M	tools/gn/BUILD.gn	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	tools/gn/file_template.h	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	tools/gn/file_template.cc	View		3 chunks	+13 lines, -4 lines	0 comments	Download
M	tools/gn/file_template_unittest.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/gn/function_get_target_outputs.cc	View	1 2 3	1 chunk	+181 lines, -0 lines	0 comments	Download
A	tools/gn/function_get_target_outputs_unittest.cc	View	1 2 3	1 chunk	+115 lines, -0 lines	0 comments	Download
M	tools/gn/function_toolchain.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	tools/gn/functions.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	tools/gn/functions.cc	View		2 chunks	+9 lines, -2 lines	0 comments	Download
M	tools/gn/gn.gyp	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	tools/gn/loader.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	tools/gn/scope.h	View	1 2	5 chunks	+27 lines, -0 lines	0 comments	Download
M	tools/gn/scope.cc	View		2 chunks	+14 lines, -3 lines	0 comments	Download
M	tools/gn/target_generator.cc	View		1 chunk	+10 lines, -2 lines	0 comments	Download
M	tools/gn/template.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/269723006/diff/40001/tools/gn/function_get_target_outputs.cc File tools/gn/function_get_target_outputs.cc (right): https://codereview.chromium.org/269723006/diff/40001/tools/gn/function_get_target_outputs.cc#newcode29 tools/gn/function_get_target_outputs.cc:29: return; these |return|s rather than break are a ...

6 years, 7 months ago (2014-05-05 16:31:15 UTC) #2

brettw

https://codereview.chromium.org/269723006/diff/40001/tools/gn/function_get_target_outputs_unittest.cc File tools/gn/function_get_target_outputs_unittest.cc (right): https://codereview.chromium.org/269723006/diff/40001/tools/gn/function_get_target_outputs_unittest.cc#newcode58 tools/gn/function_get_target_outputs_unittest.cc:58: AssertSingleStringEquals(result, "//out/Debug/bar"); I added a comment. The test scope ...

6 years, 7 months ago (2014-05-05 17:09:49 UTC) #3

brettw

6 years, 7 months ago (2014-05-05 20:28:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r268260 (presubmit successful).

Expand Messages | Collapse Messages