Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 269723005: Move [TypeChecking] to the interface for CRC2D (Closed)

Created:
6 years, 7 months ago by fs
Modified:
6 years, 7 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews, arv+blink, blink-reviews-html_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Move [TypeChecking] to the interface for CRC2D With all the methods converted the extended attribute can be moved from individual methods to the interface. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -38 lines) Patch
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 6 chunks +38 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fs
6 years, 7 months ago (2014-05-02 16:50:24 UTC) #1
Justin Novosad
On 2014/05/02 16:50:24, fs wrote: lgtm
6 years, 7 months ago (2014-05-02 17:16:23 UTC) #2
fs
The CQ bit was checked by fs@opera.com
6 years, 7 months ago (2014-05-02 17:23:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/269723005/1
6 years, 7 months ago (2014-05-02 17:23:19 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 18:53:14 UTC) #5
Message was sent while issue was closed.
Change committed as 173217

Powered by Google App Engine
This is Rietveld 408576698