Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: runtime/vm/kernel_reader.cc

Issue 2697193008: [Kernel] replace function debuggable field with originalAsyncMarker field (Closed)
Patch Set: Changes based on feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/kernel_binary.cc ('k') | runtime/vm/kernel_to_il.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_reader.cc
diff --git a/runtime/vm/kernel_reader.cc b/runtime/vm/kernel_reader.cc
index 752e42e667910e2f0b488177fb4fd96d654f8c8a..409bd46fc130014eae832f396d0977c690bf71a8 100644
--- a/runtime/vm/kernel_reader.cc
+++ b/runtime/vm/kernel_reader.cc
@@ -427,7 +427,26 @@ void KernelReader::ReadProcedure(const dart::Library& library,
function.set_end_token_pos(kernel_procedure->end_position());
owner.AddFunction(function);
function.set_kernel_function(kernel_procedure);
- function.set_is_debuggable(kernel_procedure->function()->debuggable());
+
+ function.set_is_debuggable(
+ kernel_procedure->function()->dart_async_marker() == FunctionNode::kSync);
+ switch (kernel_procedure->function()->dart_async_marker()) {
+ case FunctionNode::kSyncStar:
+ function.set_modifier(RawFunction::kSyncGen);
+ break;
+ case FunctionNode::kAsync:
+ function.set_modifier(RawFunction::kAsync);
+ break;
+ case FunctionNode::kAsyncStar:
+ function.set_modifier(RawFunction::kAsyncGen);
+ break;
+ default:
+ // no special modifier
+ break;
+ }
+ function.set_is_generated_body(kernel_procedure->function()->async_marker() ==
Kevin Millikin (Google) 2017/02/22 10:46:03 This is safe but we won't see kSyncYielding here s
jensj 2017/02/22 11:12:35 Changing to ``` ASSERT(kernel_procedure->function(
+ FunctionNode::kSyncYielding);
+
if (native_name != NULL) {
function.set_native_name(*native_name);
}
« no previous file with comments | « runtime/vm/kernel_binary.cc ('k') | runtime/vm/kernel_to_il.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698