[Kernel] replace function debuggable field with originalAsyncMarker field

pkg/kernel/lib/transformations/continuation.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library kernel.transformations.continuation;
 
 import 'dart:math' as math;
 
 import '../ast.dart';
 import '../core_types.dart';
@@ skipping 128 matching lines @@
 
     // return new _SyncIterable(:sync_body);
     final arguments = new Arguments([new VariableGet(nestedClosureVariable)]);
     final returnStatement = new ReturnStatement(
         new ConstructorInvocation(helper.syncIterableConstructor, arguments));
 
     enclosingFunction.body = new Block([]
       ..addAll(variableDeclarations())
       ..addAll([closureFunction, returnStatement]));
     enclosingFunction.body.parent = enclosingFunction;
+    enclosingFunction.originalAsyncMarker = enclosingFunction.asyncMarker;

[Kevin Millikin (Google), 2017/02/22 07:59:59]

It doesn't make sense to ever change the original async marker.  If we do that,
it might not be the original one (it's just the previous one).

I don't understand why we don't just leave it alone.

[jensj, 2017/02/22 10:36:45]

Done.

     enclosingFunction.asyncMarker = AsyncMarker.Sync;
     return enclosingFunction;
   }
 
   Statement buildClosureBody() {
     // The body will insert calls to
     //    :iterator.current_=
     //    :iterator.isYieldEach=
     // and return `true` as long as it did something and `false` when it's done.
     return new Block(<Statement>[
@@ skipping 532 matching lines @@
     statements.add(setController);
 
     // return :controller.stream;
     var completerGet = new VariableGet(controllerVariable);
     var returnStatement = new ReturnStatement(
         new PropertyGet(completerGet, new Name('stream', helper.asyncLibrary)));
     statements.add(returnStatement);
 
     enclosingFunction.body = new Block(statements);
     enclosingFunction.body.parent = enclosingFunction;
+    enclosingFunction.originalAsyncMarker = enclosingFunction.asyncMarker;

[Kevin Millikin (Google), 2017/02/22 07:59:59]

Same comment.

[jensj, 2017/02/22 10:36:45]

Done.

     enclosingFunction.asyncMarker = AsyncMarker.Sync;
     return enclosingFunction;
   }
 
   Statement buildWrappedBody() {
     ++currentTryDepth;
     Statement body = super.buildWrappedBody();
     --currentTryDepth;
 
     var finallyBody = new ExpressionStatement(new MethodInvocation(
@@ skipping 102 matching lines @@
     statements.add(newMicrotaskStatement);
 
     // return :completer.future;
     var completerGet = new VariableGet(completerVariable);
     var returnStatement = new ReturnStatement(
         new PropertyGet(completerGet, new Name('future', helper.asyncLibrary)));
     statements.add(returnStatement);
 
     enclosingFunction.body = new Block(statements);
     enclosingFunction.body.parent = enclosingFunction;
+    enclosingFunction.originalAsyncMarker = enclosingFunction.asyncMarker;

[Kevin Millikin (Google), 2017/02/22 07:59:59]

Same comment.

[jensj, 2017/02/22 10:36:45]

Done.

     enclosingFunction.asyncMarker = AsyncMarker.Sync;
-    enclosingFunction.debuggable = false;
     return enclosingFunction;
   }
 
   Statement buildCatchBody(exceptionVariable, stackTraceVariable) {
     return new ExpressionStatement(new MethodInvocation(
         new VariableGet(completerVariable),
         new Name("completeError", helper.asyncLibrary),
         new Arguments([
           new VariableGet(exceptionVariable),
           new VariableGet(stackTraceVariable)
@@ skipping 135 matching lines @@
         findConstructor(syncIterableClass, ''),
         findConstructor(streamIteratorClass, ''),
         findFactoryConstructor(futureClass, 'microtask'),
         findConstructor(streamControllerClass, ''),
         findProcedure(asyncLibrary, '_asyncThenWrapperHelper'),
         findProcedure(asyncLibrary, '_asyncErrorWrapperHelper'),
         findProcedure(asyncLibrary, '_awaitHelper'),
         new CoreTypes(program));
   }
 }