Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/safe_browsing/threat_details_cache.cc

Issue 2697193003: Network traffic annotation added to safe_browsing (Closed)
Patch Set: Comments addressed. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/threat_details_cache.cc
diff --git a/chrome/browser/safe_browsing/threat_details_cache.cc b/chrome/browser/safe_browsing/threat_details_cache.cc
index 066e06a332099be0f351cb17e7899ad338e2fbee..22aaaf30263714eedcd9b1c1974a2b3bb555b33b 100644
--- a/chrome/browser/safe_browsing/threat_details_cache.cc
+++ b/chrome/browser/safe_browsing/threat_details_cache.cc
@@ -21,6 +21,7 @@
#include "net/base/load_flags.h"
#include "net/base/net_errors.h"
#include "net/http/http_response_headers.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_request_context_getter.h"
#include "net/url_request/url_request_status.h"
@@ -81,8 +82,38 @@ void ThreatDetailsCacheCollector::OpenEntry() {
return;
}
- current_fetch_ = net::URLFetcher::Create(GURL(resources_it_->first),
- net::URLFetcher::GET, this);
+ net::NetworkTrafficAnnotationTag traffic_annotation =
+ net::DefineNetworkTrafficAnnotation("safe_browsing_cache_collector", R"(
+ semantics {
+ sender: "Threat Details Cache Collector"
+ description:
+ "This request fetches different items from safe browsing cache "
+ "and DOES NOT make an actual network request."
+ trigger:
+ "When safe browsing extended report is collecting data."
+ data:
+ "None"
+ destination: OTHER
+ }
+ policy {
+ cookies_allowed: false
+ setting:
+ "Users can enable or disable this feature by stopping sending "
+ "security incident reports to Google via disabling 'Automatically "
+ "report details of possible security incdients to Google.' in "
+ "Chrome's settings under Advanced Settings, Privacy. The feature "
+ "is disabled by default."
+ chrome_policy {
+ SafeBrowsingExtendedReportingOptInAllowed {
+ policy_options {mode: MANDATORY}
+ SafeBrowsingExtendedReportingOptInAllowed: false
+ }
+ }
+ })");
+
+ current_fetch_ =
+ net::URLFetcher::Create(GURL(resources_it_->first), net::URLFetcher::GET,
+ this, traffic_annotation);
data_use_measurement::DataUseUserData::AttachToFetcher(
current_fetch_.get(),
data_use_measurement::DataUseUserData::SAFE_BROWSING);
« no previous file with comments | « chrome/browser/safe_browsing/download_feedback_unittest.cc ('k') | chrome/browser/safe_browsing/two_phase_uploader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698