Chromium Code Reviews| Index: chrome/browser/safe_browsing/download_feedback.cc |
| diff --git a/chrome/browser/safe_browsing/download_feedback.cc b/chrome/browser/safe_browsing/download_feedback.cc |
| index d38f08118833703925890aa620f7aed25116e003..eff5c9baede10d44371dc14d349eedd1019987b0 100644 |
| --- a/chrome/browser/safe_browsing/download_feedback.cc |
| +++ b/chrome/browser/safe_browsing/download_feedback.cc |
| @@ -128,12 +128,48 @@ void DownloadFeedbackImpl::Start(const base::Closure& finish_callback) { |
| std::string metadata_string; |
| bool ok = report_metadata.SerializeToString(&metadata_string); |
| DCHECK(ok); |
| + |
| + net::NetworkTrafficAnnotationTag traffic_annotation = |
| + net::DefineNetworkTrafficAnnotation("safe_browsing_feedback", R"( |
| + semantics { |
| + sender: "Safe Browsing Download Protection Feedback" |
| + description: |
| + "When a user downloads a binary that Safe Browsing declares as " |
| + "suspicious, opted-in clients may upload that binary to Safe " |
| + "Browsing to improve the classification. This helps protect users " |
| + "from malware and unwanted software." |
| + trigger: |
| + "The browser will upload the binary to Google when a " |
| + "download-protection verdict is 'Not Safe', and the user is opted " |
| + "in to extended-reporting." |
| + data: |
| + "The suspicious binary file." |
| + destination: GOOGLE_OWNED_SERVICE |
| + } |
| + policy { |
| + cookies_allowed: true |
| + cookies_store: "Safe Browsing Cookie Store" |
| + setting: |
| + "Users can enable or disable this feature by stopping sending " |
| + "security incident reports to Google via disabling 'Automatically " |
| + "report details of possible security incdients to Google.' in " |
|
Nathan Parker
2017/03/06 17:48:54
spelling: incidents
Ramin Halavati
2017/03/07 08:24:47
Done.
|
| + "Chrome's settings under Advanced Settings, Privacy. The feature " |
| + "is enabled by default." |
|
Nathan Parker
2017/03/06 17:48:54
should be:
"is disabled by default"
Ramin Halavati
2017/03/07 08:24:47
Done.
|
| + policy { |
| + SafeBrowsingExtendedReportingOptInAllowed { |
| + policy_options {mode: MANDATORY} |
| + value: false |
| + } |
| + } |
| + })"); |
| + |
| uploader_ = TwoPhaseUploader::Create( |
| request_context_getter_.get(), file_task_runner_.get(), |
| GURL(kSbFeedbackURL), metadata_string, file_path_, |
| TwoPhaseUploader::ProgressCallback(), |
| base::Bind(&DownloadFeedbackImpl::FinishedUpload, base::Unretained(this), |
| - finish_callback)); |
| + finish_callback), |
| + traffic_annotation); |
| uploader_->Start(); |
| } |