Convert RemoveDataMask from enum to pointers and split it between content and embedder

content/public/browser/browsing_data_types.cc

Index: content/public/browser/browsing_data_types.cc
diff --git a/content/public/browser/browsing_data_types.cc b/content/public/browser/browsing_data_types.cc
new file mode 100644
index 0000000000000000000000000000000000000000..75719822343b2bf66e529dc8907a769614be6f4b
--- /dev/null
+++ b/content/public/browser/browsing_data_types.cc
@@ -0,0 +1,39 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/public/browser/browsing_data_types.h"

[Bernhard Bauer, 2017/02/17 11:10:44]

Hm... would it work to have the definition of these outside of the public
interface and only declare them in the header, or would that create a problem
with component builds? I want to say it should work, because `extern` makes the
symbol not different from e.g. a method definition, and those can definitely be
declared in a public header but implemented only in non-public files.

[msramek, 2017/02/17 18:00:20]

Yes, I think you're right.

The problem with content/public interface that I mentioned had to with the
standard pattern:
content/public/*.h -> pure virtual
content/*impl.[h|cc] -> implementation

If we broke BrowsingDataType into a pure virtual BrowsingDataType and
BrowsingDataTypeImpl, things would get a bit more complicated.

But moving just the .cc file should be fine.

+
+namespace content {
+
+const BrowsingDataType kBrowsingDataTypeAppCache { "appcache", true };
+
+const BrowsingDataType kBrowsingDataTypeFileSystems {"file systems", true};
+
+const BrowsingDataType kBrowsingDataTypeIndexedDB {"indexed db", true};
+
+const BrowsingDataType kBrowsingDataTypeLocalStorage {"local storage", true};
+
+const BrowsingDataType kBrowsingDataTypeWebSQL {"web sql", true};
+
+const BrowsingDataType kBrowsingDataTypeServiceWorkers {
+  "service workers", true
+};
+
+const BrowsingDataType kBrowsingDataTypeCacheStorage {"cache storage", true};
+
+const BrowsingDataType kBrowsingDataTypeStorage {"storage", true};
+
+const BrowsingDataType kBrowsingDataTypeCookies {"cookies", true};
+
+const BrowsingDataType kBrowsingDataTypeChannelIDs {"channel IDs", true};
+
+const BrowsingDataType kBrowsingDataTypeCache {"cache", true};
+
+const BrowsingDataType kBrowsingDataTypeDownloads {"downloads", true};
+
+const BrowsingDataType kBrowsingDataTypeMediaLicenses {"media licenses", true};
+
+const BrowsingDataType kBrowsingDataTypeNoChecks {"no checks", true};
+
+}