third_party/WebKit/Source/modules/payments/PaymentRequest.h - Issue 2697123003: Use ExecutionContext instead of Document in PaymentRequest constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.h

Issue 2697123003: Use ExecutionContext instead of Document in PaymentRequest constructor. (Closed)

Patch Set: ExecutionContext in constructor only Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/payments/PaymentRequest.h

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.h b/third_party/WebKit/Source/modules/payments/PaymentRequest.h

index 57b41a5bb4268ab298b94a952dc2b11200445e73..ee0713bdb055cbf4a4084aa24bbb008dd6f10b0c 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.h

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.h

@@ -29,6 +29,7 @@

namespace blink {

class ExceptionState;

+class ExecutionContext;

class PaymentAddress;

class ScriptPromiseResolver;

class ScriptState;

@@ -45,11 +46,11 @@ class MODULES_EXPORT PaymentRequest final

WTF_MAKE_NONCOPYABLE(PaymentRequest);

public:

- static PaymentRequest* create(Document&,

+ static PaymentRequest* create(ExecutionContext*,

const HeapVector<PaymentMethodData>&,

const PaymentDetails&,

ExceptionState&);

- static PaymentRequest* create(Document&,

+ static PaymentRequest* create(ExecutionContext*,

const HeapVector<PaymentMethodData>&,

const PaymentDetails&,

const PaymentOptions&,

@@ -88,7 +89,7 @@ class MODULES_EXPORT PaymentRequest final

void onCompleteTimeoutForTesting();

private:

- PaymentRequest(Document&,

+ PaymentRequest(ExecutionContext*,

const HeapVector<PaymentMethodData>&,

const PaymentDetails&,

const PaymentOptions&,