third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp - Issue 2697123003: Use ExecutionContext instead of Document in PaymentRequest constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

Issue 2697123003: Use ExecutionContext instead of Document in PaymentRequest constructor. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/payments/PaymentRequest.cpp ('K') | « third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentResponse.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

index 0cf18826f9797774dd7de00bc124f3db263cadb7..af9966007ee2e9999d7ae15c761906cec49c4bdf 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

@@ -126,7 +126,7 @@ TEST(PaymentRequestUpdateEventTest, OnUpdatePaymentDetailsTimeout) {

PaymentRequestMockFunctionScope funcs(scope.getScriptState());

makePaymentRequestOriginSecure(scope.document());

PaymentRequest* request = PaymentRequest::create(

- scope.document(), buildPaymentMethodDataForTest(),

+ scope.getScriptState(), buildPaymentMethodDataForTest(),

buildPaymentDetailsForTest(), scope.getExceptionState());

PaymentRequestUpdateEvent* event = PaymentRequestUpdateEvent::create(

scope.getExecutionContext(), EventTypeNames::shippingaddresschange);

@@ -134,8 +134,7 @@ TEST(PaymentRequestUpdateEventTest, OnUpdatePaymentDetailsTimeout) {

EXPECT_FALSE(scope.getExceptionState().hadException());

String errorMessage;

- request->show(scope.getScriptState())

- .then(funcs.expectNoCall(), funcs.expectCall(&errorMessage));

+ request->show().then(funcs.expectNoCall(), funcs.expectCall(&errorMessage));

event->onUpdateEventTimeoutForTesting();