third_party/WebKit/Source/modules/payments/PaymentRequest.h - Issue 2697123003: Use ExecutionContext instead of Document in PaymentRequest constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.h

Issue 2697123003: Use ExecutionContext instead of Document in PaymentRequest constructor. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentCompleter.h ('k') | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('j') | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequest.h

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.h b/third_party/WebKit/Source/modules/payments/PaymentRequest.h

index 57b41a5bb4268ab298b94a952dc2b11200445e73..353bcdde2930af63f570687a2611c5864f41e0a6 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.h

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.h

@@ -45,11 +45,11 @@ class MODULES_EXPORT PaymentRequest final

WTF_MAKE_NONCOPYABLE(PaymentRequest);

public:

- static PaymentRequest* create(Document&,

+ static PaymentRequest* create(ScriptState*,

const HeapVector<PaymentMethodData>&,

const PaymentDetails&,

ExceptionState&);

- static PaymentRequest* create(Document&,

+ static PaymentRequest* create(ScriptState*,

const HeapVector<PaymentMethodData>&,

const PaymentDetails&,

const PaymentOptions&,

@@ -57,8 +57,8 @@ class MODULES_EXPORT PaymentRequest final

virtual ~PaymentRequest();

- ScriptPromise show(ScriptState*);

- ScriptPromise abort(ScriptState*);

+ ScriptPromise show();

+ ScriptPromise abort();

PaymentAddress* getShippingAddress() const { return m_shippingAddress.get(); }

const String& shippingOption() const { return m_shippingOption; }

@@ -67,7 +67,7 @@ class MODULES_EXPORT PaymentRequest final

DEFINE_ATTRIBUTE_EVENT_LISTENER(shippingaddresschange);

DEFINE_ATTRIBUTE_EVENT_LISTENER(shippingoptionchange);

- ScriptPromise canMakePayment(ScriptState*);

+ ScriptPromise canMakePayment();

// ScriptWrappable:

bool hasPendingActivity() const override;

@@ -77,7 +77,7 @@ class MODULES_EXPORT PaymentRequest final

ExecutionContext* getExecutionContext() const override;

// PaymentCompleter:

- ScriptPromise complete(ScriptState*, PaymentComplete result) override;

+ ScriptPromise complete(PaymentComplete result) override;

// PaymentUpdater:

void onUpdatePaymentDetails(const ScriptValue& detailsScriptValue) override;

@@ -88,7 +88,7 @@ class MODULES_EXPORT PaymentRequest final

void onCompleteTimeoutForTesting();

private:

- PaymentRequest(Document&,

+ PaymentRequest(ScriptState*,

const HeapVector<PaymentMethodData>&,

const PaymentDetails&,

const PaymentOptions&,