Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: pkg/kernel/lib/transformations/continuation.dart

Issue 2697083002: Revert "Enable causal stacktrace in kernel" (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/kernel_to_il.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/transformations/continuation.dart
diff --git a/pkg/kernel/lib/transformations/continuation.dart b/pkg/kernel/lib/transformations/continuation.dart
index 65d492e2d6a0ed7b51714dd6e87fe501d2289cc5..112ea43b8274b3f3e182cc2e99039834e589fcb6 100644
--- a/pkg/kernel/lib/transformations/continuation.dart
+++ b/pkg/kernel/lib/transformations/continuation.dart
@@ -198,8 +198,6 @@ abstract class AsyncRewriterBase extends ContinuationRewriterBase {
new VariableDeclaration(":async_op_then");
final VariableDeclaration catchErrorContinuationVariable =
new VariableDeclaration(":async_op_error");
- final VariableDeclaration asyncStackTrace =
- new VariableDeclaration(":async_stack_trace");
LabeledStatement labeledBody;
@@ -217,9 +215,6 @@ abstract class AsyncRewriterBase extends ContinuationRewriterBase {
// var :async_op_error;
statements.add(catchErrorContinuationVariable);
- // var :async_stack_trace;
- statements.add(asyncStackTrace);
-
// :async_op([:result, :exception, :stack_trace]) {
// modified <node.body>;
// }
@@ -263,13 +258,6 @@ abstract class AsyncRewriterBase extends ContinuationRewriterBase {
new VariableSet(
catchErrorContinuationVariable, boundCatchErrorClosure));
statements.add(catchErrorClosureVariableAssign);
-
- // :async_stack_trace = _asyncStackTraceHelper();
- final boundAsyncStackTrace = new StaticInvocation(
- helper.asyncStackTraceHelper, new Arguments.empty());
- final asyncStackTraceVariableAssign = new ExpressionStatement(
- new VariableSet(asyncStackTrace, boundAsyncStackTrace));
- statements.add(asyncStackTraceVariableAssign);
}
Statement buildWrappedBody() {
@@ -886,7 +874,6 @@ class HelperNodes {
final Constructor streamIteratorConstructor;
final Procedure asyncThenWrapper;
final Procedure asyncErrorWrapper;
- final Procedure asyncStackTraceHelper;
final Procedure awaitHelper;
final CoreTypes coreTypes;
@@ -904,7 +891,6 @@ class HelperNodes {
this.streamControllerConstructor,
this.asyncThenWrapper,
this.asyncErrorWrapper,
- this.asyncStackTraceHelper,
this.awaitHelper,
this.coreTypes);
@@ -987,7 +973,6 @@ class HelperNodes {
findConstructor(streamControllerClass, ''),
findProcedure(asyncLibrary, '_asyncThenWrapperHelper'),
findProcedure(asyncLibrary, '_asyncErrorWrapperHelper'),
- findProcedure(asyncLibrary, '_asyncStackTraceHelper'),
findProcedure(asyncLibrary, '_awaitHelper'),
new CoreTypes(program));
}
« no previous file with comments | « no previous file | runtime/vm/kernel_to_il.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698