src/compiler/js-typed-lowering.cc - Issue 2697063002: Fix typeof optimization for undetectable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 2697063002: Fix typeof optimization for undetectable (Closed)

Patch Set: Add TypeOfIsFunction to EscapeStatusAnalysis Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-typed-lowering.cc

diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc

index c4c80bd67130daef667e3eaac00dd137590e9dfb..430ba007913e9d0836fd5c4bfbc2ede835ee3abb 100644

--- a/src/compiler/js-typed-lowering.cc

+++ b/src/compiler/js-typed-lowering.cc

@@ -949,7 +949,7 @@ Reduction JSTypedLowering::ReduceJSEqualTypeOf(Node* node, bool invert) {

graph()->NewNode(simplified()->ReferenceEqual(), input,

jsgraph()->FalseConstant()));

} else if (String::Equals(type, factory()->function_string())) {

- value = graph()->NewNode(simplified()->ObjectIsCallable(), input);

+ value = graph()->NewNode(simplified()->TypeOfIsFunction(), input);

} else if (String::Equals(type, factory()->number_string())) {

value = graph()->NewNode(simplified()->ObjectIsNumber(), input);

} else if (String::Equals(type, factory()->object_string())) {