Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: ios/chrome/browser/suggestions/suggestions_service_factory.mm

Issue 2697043005: Use component ImageFetcher instead of iOS one. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/suggestions/suggestions_service_factory.mm
diff --git a/ios/chrome/browser/suggestions/suggestions_service_factory.mm b/ios/chrome/browser/suggestions/suggestions_service_factory.mm
index daeca8b0132efabbcb609c2734bd67d042e8e750..3d8f70f0ff874fe5d38fa96f0cc2b678053cbbbc 100644
--- a/ios/chrome/browser/suggestions/suggestions_service_factory.mm
+++ b/ios/chrome/browser/suggestions/suggestions_service_factory.mm
@@ -13,6 +13,7 @@
#include "base/threading/sequenced_worker_pool.h"
#include "components/browser_sync/profile_sync_service.h"
#include "components/image_fetcher/image_fetcher.h"
+#include "components/image_fetcher/image_fetcher_impl.h"
#include "components/keyed_service/ios/browser_state_dependency_manager.h"
#include "components/leveldb_proto/proto_database_impl.h"
#include "components/signin/core/browser/profile_oauth2_token_service.h"
@@ -24,7 +25,7 @@
#include "ios/chrome/browser/browser_state/chrome_browser_state.h"
#include "ios/chrome/browser/signin/oauth2_token_service_factory.h"
#include "ios/chrome/browser/signin/signin_manager_factory.h"
-#include "ios/chrome/browser/suggestions/image_fetcher_impl.h"
+#include "ios/chrome/browser/suggestions/ios_image_decoder_impl.h"
#include "ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h"
#include "ios/web/public/browser_state.h"
#include "ios/web/public/web_thread.h"
@@ -82,18 +83,23 @@ SuggestionsServiceFactory::BuildServiceInstanceFor(
IOSChromeProfileSyncServiceFactory::GetForBrowserState(browser_state);
base::FilePath database_dir(
browser_state->GetStatePath().Append(kThumbnailDirectory));
+
std::unique_ptr<SuggestionsStore> suggestions_store(
new SuggestionsStore(browser_state->GetPrefs()));
std::unique_ptr<BlacklistStore> blacklist_store(
new BlacklistStore(browser_state->GetPrefs()));
std::unique_ptr<leveldb_proto::ProtoDatabaseImpl<ImageData>> db(
new leveldb_proto::ProtoDatabaseImpl<ImageData>(background_task_runner));
- std::unique_ptr<image_fetcher::ImageFetcher> image_fetcher(
- new ImageFetcherImpl(browser_state->GetRequestContext(),
- sequenced_worker_pool));
+
+ std::unique_ptr<image_fetcher::ImageFetcher> image_fetcher =
+ base::MakeUnique<image_fetcher::ImageFetcherImpl>(
+ CreateIOSImageDecoder(sequenced_worker_pool),
+ browser_state->GetRequestContext());
+
std::unique_ptr<ImageManager> thumbnail_manager(new ImageManager(
std::move(image_fetcher), std::move(db), database_dir,
web::WebThread::GetTaskRunnerForThread(web::WebThread::DB)));
+
justincohen 2017/02/17 14:24:31 nit remove new spaces
gambard 2017/02/17 14:26:00 I find it way more readable with the new line (add
return base::MakeUnique<SuggestionsServiceImpl>(
signin_manager, token_service, sync_service,
browser_state->GetRequestContext(), std::move(suggestions_store),

Powered by Google App Engine
This is Rietveld 408576698